Skip to content

[Lean Squad] feat: formal verification infrastructure — research & CI automation#7799

Merged
Evangelink merged 5 commits intomainfrom
lean-squad/research-and-ci-2026-04-24-a3943919f2a5931a
Apr 24, 2026
Merged

[Lean Squad] feat: formal verification infrastructure — research & CI automation#7799
Evangelink merged 5 commits intomainfrom
lean-squad/research-and-ci-2026-04-24-a3943919f2a5931a

Conversation

@Evangelink
Copy link
Copy Markdown
Member

  • Add formal-verification/ directory with research docs, targets list,
    correspondence and critique placeholders, and project report
  • Identify 5 FV targets in the command-line infrastructure:
    • ArgumentArity (priority 1, decidable properties)
    • CommandLineParser.TryUnescape (priority 2, pure string unescaping)
    • CommandLineParser.ParseOptionAndSeparators (priority 3, pure splitting)
    • CommandLineOptionsValidator arity validation (priority 4)
    • CommandLineParseResult.Equals (priority 5, structural equality laws)
  • Add formal-verification/lean/ directory with Lake build config (lakefile.toml)
  • Add .github/workflows/lean-proofs.yml CI workflow for lake build

🔬 Lean Squad — automated FV infrastructure setup.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

- Add formal-verification/ directory with research docs, targets list,
  correspondence and critique placeholders, and project report
- Identify 5 FV targets in the command-line infrastructure:
  * ArgumentArity (priority 1, decidable properties)
  * CommandLineParser.TryUnescape (priority 2, pure string unescaping)
  * CommandLineParser.ParseOptionAndSeparators (priority 3, pure splitting)
  * CommandLineOptionsValidator arity validation (priority 4)
  * CommandLineParseResult.Equals (priority 5, structural equality laws)
- Add formal-verification/lean/ directory with Lake build config (lakefile.toml)
- Add .github/workflows/lean-proofs.yml CI workflow for lake build

🔬 Lean Squad — automated FV infrastructure setup.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 24, 2026 08:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces an initial Lean 4 formal-verification workspace and documentation for tracking verification targets in the command-line infrastructure, plus CI automation to run lake build when the Lean project changes.

Changes:

  • Add formal-verification/ documentation (research notes, target list, placeholders, and report).
  • Add a Lean 4 project scaffold under formal-verification/lean/ with Mathlib dependency.
  • Add a GitHub Actions workflow to build Lean proofs on relevant PRs/pushes.
Show a summary per file
File Description
formal-verification/lean/lakefile.toml Defines the Lean/Lake project and pins Mathlib revision.
formal-verification/lean/README.md Documents project structure, local build steps, and CI behavior.
formal-verification/TARGETS.md Lists and prioritizes initial FV targets and phases.
formal-verification/RESEARCH.md Captures research rationale and candidate properties to verify.
formal-verification/REPORT.md Summarizes current status and run history.
formal-verification/CRITIQUE.md Placeholder for ongoing critique of FV utility/coverage.
formal-verification/CORRESPONDENCE.md Placeholder for Lean↔C# correspondence notes.
.github/workflows/lean-proofs.yml Adds CI job that installs Lean tooling and runs lake build.

Copilot's findings

  • Files reviewed: 8/8 changed files
  • Comments generated: 6

Comment thread formal-verification/RESEARCH.md Outdated
Comment thread formal-verification/lean/README.md
Comment thread .github/workflows/lean-proofs.yml Outdated
Comment thread formal-verification/lean/README.md Outdated
Comment thread formal-verification/RESEARCH.md Outdated
Comment thread formal-verification/RESEARCH.md Outdated
@Evangelink Evangelink enabled auto-merge April 24, 2026 08:30
Copilot AI review requested due to automatic review settings April 24, 2026 08:57
Extract precise informal specification for ArgumentArity:
- 14 properties across 4 groups (constants, well-formedness, equality, distinctness)
- Documents open question: constructor does not enforce Min ≤ Max invariant,
  which can cause undefined validator behavior for ill-formed arities
- Lists 4 open Lean-formalisation questions and explicit approximations
- Advance ArgumentArity to Phase 2 in TARGETS.md and REPORT.md

🔬 Lean Squad — automated FV agent run.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Commit pushed: b69b49f

Generated by 📐 Lean Squad, see workflow run.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Comments suppressed due to low confidence (1)

.markdownlint-cli2.jsonc:156

  • This change excludes formal-verification/**/*.md from markdownlint entirely. Since these documents are part of the repo and currently look markdownlint-compliant, ignoring the whole directory reduces lint coverage and can allow regressions. Consider removing this ignore entry (or narrowing it to truly generated artifacts) and fixing any rule violations inline if they arise.
  // Ignore patterns - files we are not in control of or auto-generated
  "ignores": [
    "SECURITY.md",
    "artifacts/tmp/**/*.md",
    "eng/**/*.md",
    "tools/**/*.md",
    "formal-verification/**/*.md",
    ".dotnet/**/*.md",
    ".github/ISSUE_TEMPLATE/**/*.md",
    ".github/skills/**/*.md",
    ".github/agents/**/*.md",
  • Files reviewed: 13/14 changed files
  • Comments generated: 5

Comment thread formal-verification/TARGETS.md
Comment thread formal-verification/RESEARCH.md
Comment thread formal-verification/lean/lakefile.toml
Comment thread .github/workflows/lean-proofs.yml
Comment thread .github/workflows/lean-proofs.yml
auto-merge was automatically disabled April 24, 2026 12:35

Merge commits are not allowed on this repository

@Evangelink Evangelink merged commit 7935278 into main Apr 24, 2026
10 checks passed
@Evangelink Evangelink deleted the lean-squad/research-and-ci-2026-04-24-a3943919f2a5931a branch April 24, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants