[Lean Squad] feat: formal verification infrastructure — research & CI automation#7799
Merged
Evangelink merged 5 commits intomainfrom Apr 24, 2026
Merged
Conversation
- Add formal-verification/ directory with research docs, targets list, correspondence and critique placeholders, and project report - Identify 5 FV targets in the command-line infrastructure: * ArgumentArity (priority 1, decidable properties) * CommandLineParser.TryUnescape (priority 2, pure string unescaping) * CommandLineParser.ParseOptionAndSeparators (priority 3, pure splitting) * CommandLineOptionsValidator arity validation (priority 4) * CommandLineParseResult.Equals (priority 5, structural equality laws) - Add formal-verification/lean/ directory with Lake build config (lakefile.toml) - Add .github/workflows/lean-proofs.yml CI workflow for lake build 🔬 Lean Squad — automated FV infrastructure setup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces an initial Lean 4 formal-verification workspace and documentation for tracking verification targets in the command-line infrastructure, plus CI automation to run lake build when the Lean project changes.
Changes:
- Add
formal-verification/documentation (research notes, target list, placeholders, and report). - Add a Lean 4 project scaffold under
formal-verification/lean/with Mathlib dependency. - Add a GitHub Actions workflow to build Lean proofs on relevant PRs/pushes.
Show a summary per file
| File | Description |
|---|---|
formal-verification/lean/lakefile.toml |
Defines the Lean/Lake project and pins Mathlib revision. |
formal-verification/lean/README.md |
Documents project structure, local build steps, and CI behavior. |
formal-verification/TARGETS.md |
Lists and prioritizes initial FV targets and phases. |
formal-verification/RESEARCH.md |
Captures research rationale and candidate properties to verify. |
formal-verification/REPORT.md |
Summarizes current status and run history. |
formal-verification/CRITIQUE.md |
Placeholder for ongoing critique of FV utility/coverage. |
formal-verification/CORRESPONDENCE.md |
Placeholder for Lean↔C# correspondence notes. |
.github/workflows/lean-proofs.yml |
Adds CI job that installs Lean tooling and runs lake build. |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 6
Extract precise informal specification for ArgumentArity: - 14 properties across 4 groups (constants, well-formedness, equality, distinctness) - Documents open question: constructor does not enforce Min ≤ Max invariant, which can cause undefined validator behavior for ill-formed arities - Lists 4 open Lean-formalisation questions and explicit approximations - Advance ArgumentArity to Phase 2 in TARGETS.md and REPORT.md 🔬 Lean Squad — automated FV agent run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Commit pushed:
|
Contributor
There was a problem hiding this comment.
Copilot's findings
Comments suppressed due to low confidence (1)
.markdownlint-cli2.jsonc:156
- This change excludes
formal-verification/**/*.mdfrom markdownlint entirely. Since these documents are part of the repo and currently look markdownlint-compliant, ignoring the whole directory reduces lint coverage and can allow regressions. Consider removing this ignore entry (or narrowing it to truly generated artifacts) and fixing any rule violations inline if they arise.
// Ignore patterns - files we are not in control of or auto-generated
"ignores": [
"SECURITY.md",
"artifacts/tmp/**/*.md",
"eng/**/*.md",
"tools/**/*.md",
"formal-verification/**/*.md",
".dotnet/**/*.md",
".github/ISSUE_TEMPLATE/**/*.md",
".github/skills/**/*.md",
".github/agents/**/*.md",
- Files reviewed: 13/14 changed files
- Comments generated: 5
JanKrivanek
approved these changes
Apr 24, 2026
auto-merge was automatically disabled
April 24, 2026 12:35
Merge commits are not allowed on this repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correspondence and critique placeholders, and project report
🔬 Lean Squad — automated FV infrastructure setup.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com