[Test Improver] Add tests for UseConditionBaseWithTestClassAnalyzer (MSTEST0041)#7809
Merged
Evangelink merged 1 commit intoApr 24, 2026
Conversation
Add 9 unit tests covering the UseConditionBaseWithTestClassAnalyzer which warns when a ConditionBaseAttribute-derived attribute is applied to a class without TestClassAttribute. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit test coverage for MSTEST0041 (UseConditionBaseWithTestClassAnalyzer), ensuring the analyzer correctly warns when ConditionBaseAttribute-derived attributes are applied to non-[TestClass] types, while allowing valid usages.
Changes:
- Introduces a new analyzer test suite covering both diagnostic and non-diagnostic scenarios for built-in condition attributes (
OSCondition,CICondition). - Adds coverage for custom
ConditionBaseAttributederivatives and for derivedTestClassAttributescenarios.
Show a summary per file
| File | Description |
|---|---|
| test/UnitTests/MSTest.Analyzers.UnitTests/UseConditionBaseWithTestClassAnalyzerTests.cs | Adds 9 unit tests validating MSTEST0041 diagnostics across built-in and custom condition attributes, including derived TestClassAttribute cases. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
JanKrivanek
approved these changes
Apr 24, 2026
Evangelink
deleted the
test-assist/useConditionBaseWithTestClass-tests-285b5ab1b712039b
branch
5 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 9 unit tests covering the UseConditionBaseWithTestClassAnalyzer which warns when a ConditionBaseAttribute-derived attribute is applied to a class without TestClassAttribute.