Skip to content

Throw PlatformNotSupportedException in STATestMethodAttribute on non-Windows #7862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 4 commits into from
Apr 27, 2026
Merged

Throw PlatformNotSupportedException in STATestMethodAttribute on non-Windows #7862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d84a20
Document STATestMethodAttribute non-Windows behaviour and add warning
Evangelink Apr 27, 2026
4670b61
Throw PlatformNotSupportedException on non-Windows instead of warning
Evangelink Apr 27, 2026
9c1512c
Also throw on non-Windows .NET Framework (Mono)
Evangelink Apr 27, 2026
06a6587
Revert NETFRAMEWORK Mono check, keep simple #if !NETFRAMEWORK guard
Copilot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/TestFramework/TestFramework/Attributes/TestMethod/STATestMethodAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ public override async Task<TestResult[]> ExecuteAsync(ITestMethod testMethod)
#if !NETFRAMEWORK
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
// TODO: Throw?
return await ExecuteCoreAsync(testMethod).ConfigureAwait(false);
throw new PlatformNotSupportedException(FrameworkMessages.STATestMethodNonWindowsNotSupported);
}
Comment thread
Evangelink marked this conversation as resolved.
#endif

Expand Down
3 changes: 3 additions & 0 deletions src/TestFramework/TestFramework/Resources/FrameworkMessages.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,4 +405,7 @@ Actual: {2}</value>
<data name="AssertScopeNestedNotAllowed" xml:space="preserve">
<value>Nested assert scopes are not allowed. Dispose the current scope before creating a new one.</value>
</data>
<data name="STATestMethodNonWindowsNotSupported" xml:space="preserve">
<value>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</value>
</data>
</root>
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Skutečnost: {2}</target>
<target state="translated">Elementy &lt;{0}&gt; se v kolekci nenachází.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">Řetězec „{0}“ nezačíná řetězcem „{1}“. {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Tatsächlich: {2}</target>
<target state="translated">Element(e) &lt;{0}&gt; ist/sind in der Auflistung nicht vorhanden.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">Die Zeichenfolge „{0}“ beginnt nicht mit der Zeichenfolge „{1}“. {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Real: {2}</target>
<target state="translated">Los elementos &lt;{0}&gt; no están presentes en la colección.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">La cadena "{0}" no empieza con la cadena "{1}". {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Réel : {2}</target>
<target state="translated">L’élément ou les éléments &lt;{0}&gt; n’est ou ne sont pas présent(s) dans la collection.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">La chaîne '{0}' ne commence pas par la chaîne '{1}'. {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Effettivo: {2}</target>
<target state="translated">Gli elementi &lt;{0}&gt; non sono presenti nella raccolta.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">La stringa '{0}' non inizia con la stringa '{1}'. {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Actual: {2}</source>
<target state="translated">要素 &lt;{0}&gt; がコレクション内に存在しません。</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">文字列 '{0}' は文字列 '{1}' で始まりません。{2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Actual: {2}</source>
<target state="translated">컬렉션에 &lt;{0}&gt; 요소가 없습니다.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">'{0}' 문자열이 '{1}' 문자열로 시작되지 않습니다. {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Rzeczywiste: {2}</target>
<target state="translated">Elementy &lt;{0}&gt; nie występują w kolekcji.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">Ciąg „{0}” nie rozpoczyna się od ciągu „{1}”. {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Real: {2}</target>
<target state="translated">O(s) elemento(s) &lt;{0}&gt; não está/estão presente(s) na coleção.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">A cadeia de caracteres “{0}” não começa com a cadeia de caracteres “{1}”. {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Actual: {2}</source>
<target state="translated">Элементы &lt;{0}&gt; отсутствуют в коллекции.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">Строка "{0}" не начинается со строки "{1}". {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Gerçekte olan: {2}</target>
<target state="translated">Öğe(ler) &lt;{0}&gt; koleksiyonda mevcut değildir.</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">'{0}' dizesi, '{1}' dizesi ile başlamıyor. {2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Actual: {2}</source>
<target state="translated">集合中不存在元素 &lt;{0}&gt;。</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">字符串 '{0}' 不以字符串 '{1}' 开头。{2}</target>
Expand Down
5 changes: 5 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,11 @@ Actual: {2}</source>
<target state="translated">集合中不存在元素 &lt;{0}&gt;。</target>
<note />
</trans-unit>
<trans-unit id="STATestMethodNonWindowsNotSupported">
<source>[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</source>
<target state="new">[STATestMethod] is not supported on non-Windows platforms. STA (Single Threaded Apartment) is a Windows-only COM threading concept. Use [OSCondition(OperatingSystems.Windows)] to skip this test on non-Windows platforms.</target>
<note />
</trans-unit>
<trans-unit id="StartsWithFail">
<source>String '{0}' does not start with string '{1}'. {2}</source>
<target state="translated">字串 '{0}' 不是以字串 '{1}' 開頭。{2}</target>
Expand Down