Localized file check-in by OneLocBuild Task: Build definition ID 1218: Build ID 2972073#8107
Conversation
…: Build ID 2972050
…: Build ID 2972050
There was a problem hiding this comment.
Pull request overview
This PR is an automated OneLocBuild check-in updating localized .xlf files for Microsoft.Testing.Platform and MSTest analyzer code-fix resources.
Changes:
- Updates multiple
PlatformResources.*.xlffiles forCompositeServiceFactoryInstanceAlreadyRegistered, including marking the translation astranslated. - Updates Italian
CodeFixResources.it.xlffor theRemoveDuplicateDataRowFixlocalized string.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf | Updates zh-Hant localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf | Updates zh-Hans localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf | Updates tr localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf | Updates ru localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf | Updates pt-BR localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf | Updates pl localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf | Updates ko localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf | Updates ja localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf | Updates it localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf | Updates fr localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf | Updates es localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf | Updates de localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf | Updates cs localized entry for CompositeServiceFactoryInstanceAlreadyRegistered. |
| src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.it.xlf | Updates Italian localized title for RemoveDuplicateDataRowFix. |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">已註冊 'CompositeExtensonFactory' 的同一執行個體</target> |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">“CompositeExtensonFactory”的同一实例已注册</target> |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">Aynı 'CompositeExtensonFactory' örneği zaten kayıtlı</target> |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">Такой же экземпляр CompositeExtensonFactory уже зарегистрирован</target> |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">A mesma instância de “CompositeExtensonFactory” já está registrada</target> |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">La même instance de « CompositeExtensonFactory » est déjà inscrite</target> |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">La misma instancia de "CompositeExtensonFactory" ya está registrada</target> |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">Die gleiche Instanz von "CompositeExtensonFactory" ist bereits registriert</target> |
| <source>The same instance of 'CompositeExtensonFactory' is already registered</source> | ||
| <target state="translated">Už je zaregistrovaná stejná instance CompositeExtensonFactory.</target> |
| <trans-unit id="RemoveDuplicateDataRowFix"> | ||
| <source>Remove duplicate 'DataRow'</source> | ||
| <target state="translated">Rimuovere 'DataRow' duplicato</target> | ||
| <target state="translated">Rimuovere ''DataRow'' duplicato</target> |
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Summary
Workflow: PR Nitpick Reviewer 🔍
Date: 2026-05-11
Repository: microsoft/testfx
Key Findings
This is an automated OneLocBuild localization check-in touching 14 XLF files. Two subtle issues are worth a look:
-
Important – XLF source/resx mismatch (typo): All 12
PlatformResources.*.xlffiles now contain<source>The same instance of 'CompositeExtensonFactory' is already registered</source>—CompositeExtensonFactoryis missing the letter i. The actualPlatformResources.resxsource string spells it correctly asCompositeExtensionFactory. The XLF<source>should mirror the.resxsource verbatim to keep the pipeline stable. -
Minor – Inconsistent apostrophe escaping in Italian CodeFix translation:
CodeFixResources.it.xlfchanges'DataRow'→''DataRow''(doubled apostrophes). This is the correct escaping forString.Formatusage, but the English.resxsource still uses single apostrophes. If the string is format-interpolated, the source should be updated too; if not, the translation should revert to match.
Recommendations
- Verify whether the
.resxsource forCompositeServiceFactoryInstanceAlreadyRegisteredwas intentionally changed upstream or if a typo was silently introduced in the localization roundtrip. - Clarify
String.Formatusage forRemoveDuplicateDataRowFixand align apostrophe escaping in both source and all translations.
Generated by PR Nitpick Reviewer
🔍 Meticulously inspected by PR Nitpick Reviewer 🔍
| @@ -163,8 +163,8 @@ | |||
| <note /> | |||
| </trans-unit> | |||
| <trans-unit id="CompositeServiceFactoryInstanceAlreadyRegistered"> | |||
There was a problem hiding this comment.
Nitpick (Important): The <source> element now reads 'CompositeExtensonFactory' (missing the letter i), but the canonical English string in PlatformResources.resx is 'CompositeExtensionFactory' (correct spelling). XLIFF <source> elements should stay in sync with the .resx source to keep the localization pipeline consistent.
The same discrepancy is present across all 12 language XLF files updated in this PR (cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant).
Why it matters: If the XLF <source> diverges from the .resx source, the next OneLocBuild run may flag all these strings as "changed" and re-queue them for translation unnecessarily, or it may silently mask a misspelling that could surface in diagnostic messages.
| @@ -69,7 +69,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="RemoveDuplicateDataRowFix"> | |||
| <source>Remove duplicate 'DataRow'</source> | |||
There was a problem hiding this comment.
Nitpick (Minor): The Italian translation now uses ''DataRow'' (doubled apostrophes) while the English source string in the .resx is Remove duplicate 'DataRow' (single apostrophes).
In .NET resource strings, apostrophes must be doubled ('') when the value is consumed through String.Format/composite formatting; they should remain single otherwise. If this string is used with String.Format, the source .resx entry should also use ''DataRow'' for consistency. If it is not, the Italian translation should revert to single quotes to match.
Why it matters: Mismatched escaping leads to strings rendering differently in different locales — Italian users would see DataRow with no surrounding quotes if String.Format is applied.
dotnet-bot
changed the title
…: Build ID 2972063
dotnet-bot
changed the title
…: Build ID 2972073 (#8107)
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.