Update BinlogMcp NuGet feed from dotnet-eng to dotnet-tools#8456
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Build Failure Analysis agentic workflows and agent footer link to use the new dotnet-tools Azure Artifacts NuGet feed for AITools.BinlogMcp, replacing the deprecated dotnet-eng feed.
Changes:
- Switched the
nuget.configpackage source used by the build-failure-analysis workflows fromdotnet-engtodotnet-tools. - Updated the explanatory comment about fork PR behavior to reference
dotnet-tools. - Updated the agent output footer link to point to the
dotnet-toolsfeed.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/build-failure-analysis.md | Updates the NuGet feed used to install AITools.BinlogMcp during build-failure analysis runs. |
| .github/workflows/build-failure-analysis-command.md | Updates the NuGet feed used by the slash-command rerun workflow. |
| .github/agents/build-failure-analyst.agent.md | Updates the footer link to the AITools.BinlogMcp package in the new feed. |
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Review Summary
The feed migration from dotnet-eng → dotnet-tools is consistent across all three changed files (feed key name, NuGet package source URL, _artifacts browse link in the agent footer, and the inline comment). The factual motivation matches the PR description (package moved, old feed being deleted).
| Dimension | Result |
|---|---|
| Algorithmic Correctness | ✅ All references updated consistently |
| Build Infrastructure & Dependencies | .lock.yml files (see inline comment) |
| Documentation Accuracy | ✅ Comment on fork-PR skip updated |
| Security | ✅ No concerns — both feeds are public dnceng feeds |
| Scope & PR Discipline | ✅ Tightly focused, one logical change |
One finding: the two modified agentic workflow source files (build-failure-analysis.md, build-failure-analysis-command.md) have no corresponding compiled .lock.yml files in the repo. Every other agentic workflow .md in .github/workflows/ has a paired .lock.yml. Per the contributing guidelines, gh aw compile should be run after modifying these sources and the regenerated lock files committed in the same PR.
Generated by Expert Code Review (on open) for issue #8456 · ● 12.3M
The AITools.BinlogMcp package is being moved from the dotnet-eng feed to dotnet-tools. The dotnet-eng feed will be deleted. Updated in: - build-failure-analysis.md (nuget.config + fork PR comment) - build-failure-analysis-command.md (nuget.config) - build-failure-analyst.agent.md (footer link) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
YuliiaKovalova
force-pushed
the
ykovalova/update-binlogmcp-feed
branch
from
d1e59e0 to
b4fa22b
Compare
Per reviewer feedback: - Compile build-failure-analysis.lock.yml and build-failure-analysis-command.lock.yml via gh aw compile --strict - Fix footer SHA to use GH_AW_PR_HEAD_SHA (the resolved PR head) instead of github.sha (which may be wrong for workflow_dispatch) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
YuliiaKovalova
force-pushed
the
ykovalova/update-binlogmcp-feed
branch
from
b4fa22b to
49fdfde
Compare
The \AITools.BinlogMcp\ package is being moved from the \dotnet-eng\ feed to \dotnet-tools. The \dotnet-eng\ feed will be deleted.