Skip to content

Fix HangDump artifact paths for Windows directories with spaces#8513

Draft
Copilot wants to merge 5 commits into
mainfrom
copilot/fix-hangdump-artifact-paths
Draft

Fix HangDump artifact paths for Windows directories with spaces#8513
Copilot wants to merge 5 commits into
mainfrom
copilot/fix-hangdump-artifact-paths

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

HangDump quoted dump paths before calling DiagnosticsClient.WriteDump on Windows, then reused that quoted string for artifact publication. This produced FileArtifact paths containing literal quotes, which do not point to the dump file on disk.

  • Path handling
    • Split dump path handling into two values:
      • quoted path for the Windows WriteDump workaround
      • unquoted path for _dumpFiles and artifact publication
DumpFileNames dumpFileNames = GetDumpFileNames(finalDumpFileName);

diagnosticsClient.WriteDump(dumpType.Value, dumpFileNames.WriteDumpFileName, logDumpGeneration: false);
_dumpFiles.Add(dumpFileNames.ArtifactDumpFileName);
  • Regression coverage
    • Added unit coverage for a Windows dump path containing spaces.
    • Verifies only the WriteDump argument is quoted and the artifact path remains unquoted.

Copilot AI self-assigned this May 22, 2026
Copilot AI review requested due to automatic review settings May 22, 2026 16:03
Copilot AI review requested due to automatic review settings May 22, 2026 16:03
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 22, 2026 16:29
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 22, 2026 16:31
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 22, 2026 16:34
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 22, 2026 16:35
Copilot AI changed the title [WIP] Fix HangDump artifact paths on Windows Fix HangDump artifact paths for Windows directories with spaces May 22, 2026
Copilot AI requested a review from Evangelink May 22, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MTP Diagnostic Analysis] HangDump publishes quoted dump paths as artifacts on Windows

2 participants