Skip to content

Align HTML report filename path semantics with TRX#8523

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/mtp-cli-analysis-report-filename-path-semantics
Draft

Align HTML report filename path semantics with TRX#8523
Copilot wants to merge 3 commits into
mainfrom
copilot/mtp-cli-analysis-report-filename-path-semantics

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 23, 2026

--report-html-filename and --report-trx-filename looked like sibling options but accepted different path shapes. HTML rejected nested paths while TRX accepted relative paths, absolute paths, and placeholders.

  • HTML filename validation

    • Allows bare filenames, relative paths, and absolute paths.
    • Rejects relative paths that escape the test results directory.
    • Keeps .html leaf extension validation.
  • HTML report output

    • Resolves standard artifact placeholders: {pname}, {pid}, {asm}, {tfm}, {time}.
    • Creates missing output directories.
    • Preserves absolute-path override behavior, matching TRX.
  • Help and tests

    • Updates help text to document the expanded contract.
    • Adds focused unit coverage for validation, placeholder resolution, sanitization, and directory handling.
    • Updates acceptance coverage for nested HTML report paths.

Example:

dotnet test --report-html --report-html-filename artifacts/run_{tfm}.html
dotnet test --report-html --report-html-filename /tmp/run.html

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 23, 2026 16:04
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 23, 2026 16:07
Copilot AI changed the title [WIP] Fix incompatible path semantics for report-html-filename and report-trx-filename Align HTML report filename path semantics with TRX May 23, 2026
Copilot AI requested a review from Evangelink May 23, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MTP CLI Analysis] report-html-filename and report-trx-filename expose incompatible path semantics

2 participants