Skip to content

Add workflow catalog and CONTRIBUTING agentic workflow section (#8587)#8599

Merged
Evangelink merged 2 commits into
mainfrom
dev/amauryleve/workflow-catalog
May 26, 2026
Merged

Add workflow catalog and CONTRIBUTING agentic workflow section (#8587)#8599
Evangelink merged 2 commits into
mainfrom
dev/amauryleve/workflow-catalog

Conversation

@Evangelink
Copy link
Copy Markdown
Member

Fixes #8587 (partial — see assessment below).

What's in this PR

  • Adds .github/workflows/README.md, a single source of truth that catalogs:
    • The 28 agentic workflows (*.md*.lock.yml), grouped by purpose (review, build/test diagnostics, continuous quality improvers, issue/PR housekeeping)
    • The 10 regular *.yml workflows
    • The 7 shared/*.md reusable components and who imports them
  • Adds an Agentic Workflows section to CONTRIBUTING.md that points at the new catalog and restates the non-negotiable rules (.md is the source of truth, lock files are regenerated by gh aw compile, strict mode is mandatory, never hand-edit lock files / generated manifests).

Assessment of #8587's 5 tasks

The originating issue is an auto-generated report from repository-quality-improver proposing 5 tasks. I reviewed each before implementing:

# Task Verdict
1 Workflow testing infrastructure (test/workflows/) ⚠️ Mostly redundant — gh aw compile --strict already validates frontmatter, action pinning, network policy, and safe-output usage. A separate test framework would duplicate this and require committing extra tooling.
2 Observability standards (shared component for summaries/annotations) ❌ Speculative — gh-aw generates the .lock.yml from the .md; adding an imports: for a "patterns" doc doesn't inject `` writes into generated jobs. GitHub Actions already provides per-run logs.
3 Workflow documentation (README + CONTRIBUTING) Implemented here. Concrete, low-risk, and the repo had no central catalog.
4 Versioning strategy (version:/changelog: frontmatter) ❌ Not viable — those are not valid gh-aw frontmatter fields and would fail strict-mode validation. Workflows are already versioned via git.
5 Shared error-handling.md component ❌ Speculative — gh-aw already provides AWF sandbox + safe-outputs: for structured error handling; a markdown "patterns" doc imported by every workflow doesn't change runtime behavior.

PR strategy

I went with a single PR because Task 3 is the only task I judged worth doing, and it's small enough not to warrant splitting (one new doc + one section in CONTRIBUTING).

Validation

  • CONTRIBUTING.md lints clean against the repo's .markdownlint-cli2.jsonc config.
  • .github/workflows/README.md is excluded from CI markdownlint (the directory is excluded for the agentic workflow .md sources, which have non-standard frontmatter), but I verified it passes the same rules locally.

Adds .github/workflows/README.md cataloging every regular and agentic
workflow in the repo (28 agentic + 10 regular + 7 shared components),
grouped by purpose, and links to gh-aw conventions.

Also extends CONTRIBUTING.md with a short "Agentic Workflows" section
that points contributors to the catalog and restates the non-negotiable
rules: the .md is the source of truth, lock files are regenerated by
`gh aw compile`, and strict mode is mandatory.

Addresses Task 3 from #8587. Tasks 1, 2, 4, and 5 from that issue were
assessed and intentionally skipped:
 - Task 1 (workflow testing infra): gh aw compile --strict already
   validates; a separate test/workflows framework is over-engineered.
 - Task 2 (observability shared component): gh-aw generates the
   .lock.yml from the .md; a shared "observability" import wouldn't
   inject summaries into generated jobs.
 - Task 4 (version:/changelog: frontmatter): not valid gh-aw fields;
   would fail strict-mode validation. Workflows are versioned via git.
 - Task 5 (error-handling shared component): gh-aw already provides
   AWF sandbox + safe-outputs; markdown "pattern docs" don't change
   runtime behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 26, 2026 10:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds contributor-facing documentation for the repository’s GitHub Actions ecosystem, with a focus on agentic workflows authored via gh aw.

Changes:

  • Adds a workflow catalog at .github/workflows/README.md (agentic workflows, regular workflows, shared components, and conventions).
  • Adds an “Agentic Workflows” section to CONTRIBUTING.md linking to the catalog and restating key rules (source-of-truth .md, regenerate .lock.yml, strict mode, don’t edit generated artifacts).
Show a summary per file
File Description
CONTRIBUTING.md Adds contributor guidance for working with agentic workflows and points to the new catalog.
.github/workflows/README.md Introduces a central workflow catalog and conventions/quick-start commands for gh aw.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 3

Comment thread CONTRIBUTING.md Outdated
Comment thread .github/workflows/README.md Outdated
Comment thread .github/workflows/README.md Outdated
Copilot review noted that .github/workflows/package.json, requirements.txt, and go.mod do not currently exist in the repo. Reworded the three mentions to make clear those manifests are only emitted by `gh aw compile` for workflows that need them, so the guidance stays accurate whether or not they're present.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member Author

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 21/21 dimensions clean — no findings.

This documentation-only PR adds a comprehensive workflow catalog to .github/workflows/README.md and updates CONTRIBUTING.md with agentic workflow guidelines.

Verified:

  • ✅ All 28 agentic workflow filenames match filesystem
  • ✅ All 10 regular workflow filenames match filesystem
  • ✅ All 7 shared component filenames match filesystem
  • ✅ Counts are accurate (28 agentic, 10 regular, 7 shared)
  • ✅ File references use correct relative paths
  • ✅ Organization is logical and scannable
  • ✅ Scope is focused and appropriate
  • ✅ markdownlint correctly excludes .github/workflows/ (agentic sources have non-standard frontmatter)

The catalog provides excellent discoverability for the repository's extensive workflow ecosystem.

Generated by Expert Code Review (on open) for issue #8599 · ● 1M

Evangelink added a commit that referenced this pull request May 26, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink Evangelink force-pushed the dev/amauryleve/workflow-catalog branch from 8682672 to 6834f63 Compare May 26, 2026 11:02
@Evangelink Evangelink enabled auto-merge (squash) May 26, 2026 12:08
@Evangelink Evangelink merged commit efe6c1f into main May 26, 2026
33 of 39 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/workflow-catalog branch May 26, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🎯 Repository Quality Improvement: Agentic Workflow Maintainability & Evolution

3 participants