bug: Do not fail on accessibility check when it's an OCI image#81
Closed
ndubchak wants to merge 2 commits into
Closed
bug: Do not fail on accessibility check when it's an OCI image#81ndubchak wants to merge 2 commits into
ndubchak wants to merge 2 commits into
Conversation
bfjelds
reviewed
Aug 4, 2025
| } | ||
|
|
||
| func checkUrlIsAccessible(url string) error { | ||
| // If this is an OCI image, skip check |
Member
There was a problem hiding this comment.
nit: maybe add reason for skipping. something like 'skip check because oci:// is not a supported protocol for http.Head'?
Member
There was a problem hiding this comment.
or maybe we could use the same translation code that Ayana has in trident for the tests go get the equivalent http address for an oci url.
Contributor
Author
There was a problem hiding this comment.
Maybe I'll leave this to @ayaegashi then
Contributor
Author
There was a problem hiding this comment.
Not sure where that translation takes place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
This PR skips checking if a URL is accessible if the image is an OCI.