Skip to content

bug: Do not fail on accessibility check when it's an OCI image #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndubchak wants to merge 2 commits into from
Closed

bug: Do not fail on accessibility check when it's an OCI image #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01db0f3
Do not fail when it's OCI
ndubchak Aug 4, 2025
32b128a
Updated error message
ndubchak Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/storm/helpers/ab_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,12 @@ func (h *AbUpdateHelper) checkTridentService(tc storm.TestCase) error {
}

func checkUrlIsAccessible(url string) error {
// If this is an OCI image, skip check
Copy link
Copy Markdown
Member

@bfjelds bfjelds Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe add reason for skipping. something like 'skip check because oci:// is not a supported protocol for http.Head'?

Copy link
Copy Markdown
Member

@bfjelds bfjelds Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe we could use the same translation code that Ayana has in trident for the tests go get the equivalent http address for an oci url.

Copy link
Copy Markdown
Contributor Author

@ndubchak ndubchak Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'll leave this to @ayaegashi then

Copy link
Copy Markdown
Contributor Author

@ndubchak ndubchak Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where that translation takes place

if strings.HasPrefix(url, "oci://") {
logrus.Infof("Skipping accessibility check for OCI URL because OCI protocol is not supported by http: %s", url)
return nil
}

resp, err := http.Head(url)
if err != nil {
return fmt.Errorf("failed to check new image URL: %w", err)
Expand Down