Skip to content

Conversation

@guybedford
Copy link
Contributor

This implements a workaround for webpack/webpack#11613 that is compatible both with Node.js and Webpack.

@weswigham
Copy link
Member

I'm more comfortable with #129, since this would pollute our wrapper code in a strange, unexplainable way, while that PR gets us closer to just having webpack respect the module entrypoint, as it used to.

@weswigham
Copy link
Member

Like, I just don't wanna handle two runtimes which do different things with the import using the same code. Moreover, the only reason there's a wrapper is so that in node we only load one copy of the library - in webpack, the module field made sure that one copy was the esm copy. We really just wanna continue that behavior.

@orta
Copy link
Contributor

orta commented Oct 9, 2020

Thanks guy! #129 is now merged and deployed

@orta orta closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants