Fix date-only range stop dropping the final day (half-open [start, stop)) - #309
Merged
Bernhard Merkle (bmerkle) merged 2 commits intoAug 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an off-by-one-day bug when compiling date-only stop bounds in date_range_from_datetime_range, aligning the system around the half-open interval convention [start, stop) so the final day is not silently excluded.
Changes:
- Introduces
exclusive_stop_from_date_time()so date-only stops compile to the next day’s midnight (exclusive bound). - Updates
DateRangesemantics/docs and__contains__to be half-open (start <= dt < end). - Adds/updates tests covering date-only stops, explicit-time stops, rollover cases, and half-open containment behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_searchlang_compile.py | Adds regression + unit tests for exclusive-stop compilation and date-range behavior. |
| tests/test_interfaces.py | Adds containment tests verifying DateRange is half-open and unbounded when end=None. |
| src/typeagent/knowpro/searchlang.py | Switches stop compilation to an exclusive bound via exclusive_stop_from_date_time(). |
| src/typeagent/knowpro/interfaces_core.py | Updates DateRange documentation and containment semantics to [start, end). |
| src/typeagent/knowpro/convutils.py | Documents that the conversation time range is for prompt display and not for index lookups. |
1 task
Collaborator
|
Too much copilot slop to review. Is there a brief summary of the changes and their consequences? |
…op)) A search time range whose stop_date carries no time compiled to that day's midnight, so "Jan 1 to Jan 5" became [Jan 1 00:00, Jan 5 00:00) and every message on Jan 5 was silently excluded. Reported in PR microsoft#296. Both timestamp index backends already filter half-open (get_in_range: "End is exclusive"; SQLite: start_timestamp >= ? AND start_timestamp < ?), so the fix is to make the compiled stop the exclusive bound the storage layer expects: for a bare date, midnight of the following day. A stop with an explicit time is already exclusive and is kept as-is. This follows the [start, stop) convention agreed in PR microsoft#198 and documented in AGENTS.md, rather than padding an inclusive end to 23:59:59.999999. Also fixes two boundary inconsistencies this uncovered: - DateRange documented and implemented its end as inclusive (start <= dt <= end) while both storage backends excluded it. It is now documented and implemented as half-open, so the two scope-filtering paths agree: with a timestamp index (lookup_range) and without one (get_text_range_for_date_range, which uses __contains__). - get_time_range_for_conversation builds an inclusive-looking end from the last message's timestamp; documented as prompt-display only, not for index lookups. get_enclosing_date_range_for_text_range already used the exclusive end ordinal's timestamp, so it needed no change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Bernhard Merkle (bmerkle)
force-pushed
the
fix-date-range-half-open
branch
from
August 4, 2026 20:27
07e575c to
f85e3f2
Compare
Collaborator
Author
|
Summary of changes are in description now shorter. |
Contributor
|
Bernhard Merkle (@bmerkle) I took you up on the offer from #296 — the half-open version is in #312, built on your design and with you credited on the commit. Close this one whenever suits you. |
Guido van Rossum (gvanrossum)
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
date_range_from_datetime_rangecompiled astop_datewith no time to that day's midnight, so a query like "Jan 1 to Jan 5" became[Jan 1 00:00, Jan 5 00:00)and every message on Jan 5 was silently dropped.Reproduced on
mainbefore the fix:This is the bug reported by Shadow_Lu (@LuShadowX) in #296 — credit for finding it goes to them. That PR fixed it by padding the (then inclusive) end to
23:59:59.999999; this PR fixes it with the half-open[start, stop)convention agreed in #198 and documented in AGENTS.md instead.The fix
Three source edits
Tests: one regression test for the bug, unit tests for the new helper, two DateRange.contains tests, and test_start_and_stop updated to expect Jan 1 instead of Dec 31.
Full
makeis green: isort/black clean, pyright clean, 756 tests pass, build OK.