Fixed document highlight for reference directive

[johnfav03]

Fixes #1892

Fixed crash produced by nil parent in accessKind, then fixed incorrect behavior in findAllReferences.go and documentHighlights.go. The textRange from the reference wasn't being returned by getReferencedSymbolsForModule, and getSemanticHighlights unnecessarily checked the status of the reference's node.

[jakebailey]

Seems right, but do you have a test that can show this?

[jakebailey]

Ah yes, Strada said:

function accessKind(node: Node): AccessKind {
    const { parent } = node;

    switch (parent?.kind) {

Love the ol "parent is never undefined except when it totally is"

[DanielRosenwasser]

Test

[Copilot]

Pull Request Overview

This PR fixes a crash and incorrect behavior in document highlighting for reference directives. The fix addresses issue #1892 where requesting highlights on a reference directive path would crash due to a nil parent in accessKind and fail to return proper highlight ranges.

Key changes:

• Added nil check in accessKind to prevent crashes when processing reference directive nodes
• Changed getReferencedSymbolsForModule to be a method on LanguageService to access LSP range creation utilities
• Fixed reference entry creation for reference directives to return proper text ranges instead of node-based entries
• Removed unnecessary node nil check in getSemanticDocumentHighlights that was preventing reference directive highlights

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/ast/ast.go	Added nil parent guard in accessKind and fixed missing closing brace
internal/ls/findallreferences.go	Changed getReferencedSymbolsForModule to instance method and fixed reference entry creation for directives
internal/ls/documenthighlights.go	Removed unnecessary node nil check that blocked reference directive highlights
internal/fourslash/tests/documentHighlightReferenceDirective_test.go	Added test case for document highlighting on reference directives
testdata/baselines/reference/fourslash/documentHighlights/documentHighlightReferenceDirective.baseline.jsonc	Added baseline output for the new test

Outdated

[jakebailey]

LGTM, ast package fix is sufficient to fix the crash but the other stuff appears to improve the output.