Temporarily work around golangci-lint custom git bug #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
approved these changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a temporary workaround for a golangci-lint bug (issue #6205) that affects GitHub Actions environments with a regressed version of git. The fix hardcodes a specific golangci-lint version instead of reading it from the configuration file.
Key changes:
- Comments out the logic that reads the golangci-lint version from
.custom-gcl.yml - Hardcodes version
v2.6.3-0.20251130135459-0212d7c8deacwith a reference to the upstream issue
| // if (!match) { | ||
| // throw new Error("Expected version in .custom-gcl.yml"); | ||
| // } | ||
| // const version = match[1]; |
There was a problem hiding this comment.
Since this is a temporary workaround, consider adding a TODO or FIXME comment to remind future maintainers to revert this change once the golangci-lint issue is resolved. For example:
// TODO: Revert to reading from .custom-gcl.yml once https://github.com/golangci/golangci-lint/issues/6205 is resolved
const version = "v2.6.3-0.20251130135459-0212d7c8deac"; // https://github.com/golangci/golangci-lint/issues/6205
Suggested change
| // const version = match[1]; | |
| // const version = match[1]; | |
| // TODO: Revert to reading from .custom-gcl.yml once https://github.com/golangci/golangci-lint/issues/6205 is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See golangci/golangci-lint#6205; GHA now has the regressed version of git.