Skip to content

Temporarily work around golangci-lint custom git bug #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
Merged

Temporarily work around golangci-lint custom git bug #2181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions Herebyfile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,13 +399,14 @@ const customLinterPath = "./_tools/custom-gcl";
const customLinterHashPath = customLinterPath + ".hash";

const golangciLintPackage = memoize(() => {
const golangciLintYml = fs.readFileSync(".custom-gcl.yml", "utf8");
const pattern = /^version:\s*(v\d+\.\d+\.\d+).*$/m;
const match = pattern.exec(golangciLintYml);
if (!match) {
throw new Error("Expected version in .custom-gcl.yml");
}
const version = match[1];
// const golangciLintYml = fs.readFileSync(".custom-gcl.yml", "utf8");
// const pattern = /^version:\s*(v\d+\.\d+\.\d+).*$/m;
// const match = pattern.exec(golangciLintYml);
// if (!match) {
// throw new Error("Expected version in .custom-gcl.yml");
// }
// const version = match[1];
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a temporary workaround, consider adding a TODO or FIXME comment to remind future maintainers to revert this change once the golangci-lint issue is resolved. For example:

// TODO: Revert to reading from .custom-gcl.yml once https://github.com/golangci/golangci-lint/issues/6205 is resolved
const version = "v2.6.3-0.20251130135459-0212d7c8deac"; // https://github.com/golangci/golangci-lint/issues/6205
Suggested change
// const version = match[1];
// const version = match[1];
// TODO: Revert to reading from .custom-gcl.yml once https://github.com/golangci/golangci-lint/issues/6205 is resolved

Copilot uses AI. Check for mistakes.
const version = "v2.6.3-0.20251130135459-0212d7c8deac"; // https://github.com/golangci/golangci-lint/issues/6205
const major = version.split(".")[0];
const versionSuffix = ["v0", "v1"].includes(major) ? "" : "/" + major;

Expand Down