Accept CJS module.exports = {} baseline diffs#3855
Merged
Conversation
…th inlined object type) Move 15 diff files from submoduleTriaged to submoduleAccepted for issue #3543. These diffs reflect intentional changes where CJS module.exports = {} patterns now emit export = _default with an inlined object type instead of individual named exports. Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate CJS module.exports emission changes
Accept CJS May 15, 2026
module.exports = {} baseline diffs
RyanCavanaugh
approved these changes
May 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the submodule baseline bookkeeping to treat a set of CommonJS module.exports = {} JS declaration emit diffs as “accepted” rather than “triaged”, reflecting that these output differences are now considered non-concerning for the port.
Changes:
- Removed the CJS
module.exports = {}diff group (15 entries) fromtestdata/submoduleTriaged.txt. - Added the same diff group to
testdata/submoduleAccepted.txt, placed alongside other CJS-related accepted groups. - Added the corresponding 15
.diffbaseline files undertestdata/baselines/reference/submoduleAccepted/.
Show a summary per file
| File | Description |
|---|---|
| testdata/submoduleTriaged.txt | Removes the CJS module.exports = {} diff group from the triaged list. |
| testdata/submoduleAccepted.txt | Adds the CJS module.exports = {} diff group to the accepted list (15 entries) with issue link. |
| testdata/baselines/reference/submoduleAccepted/compiler/jsDeclarationEmitExportAssignedArray.js.diff | Adds accepted baseline diff for CJS export-assigned array declaration emit. |
| testdata/baselines/reference/submoduleAccepted/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff | Adds accepted baseline diff for CJS export-assigned function + typedef members emit. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsCommonjsRelativePath.js.diff | Adds accepted baseline diff for CJS relative-path declaration emit. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff | Adds accepted baseline diff for doc-comment emission under CJS export assignment pattern. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff | Adds accepted baseline diff for CJS export assignment expression + secondary exports. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff | Adds accepted baseline diff for keyword-named property under CJS export assignment. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportedClassAliases.js.diff | Adds accepted baseline diff for exported class alias shapes under CJS export assignment. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff | Adds accepted baseline diff for import-alias exposure patterns within CJS namespace-like exports. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff | Adds accepted baseline diff for CJS alias re-export patterns. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff | Adds accepted baseline diff for cross-file class instance references under CJS export assignment. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeAliases.js.diff | Adds accepted baseline diff for type alias emission changes under CJS export assignment. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeReferences(target=es2015).js.diff | Adds accepted baseline diff for type reference emission changes under CJS export assignment. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff | Adds accepted baseline diff for additional type reference emission changes under CJS export assignment. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypedefAndImportTypes.js.diff | Adds accepted baseline diff for typedef + import type emission changes under CJS export assignment. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff | Adds accepted baseline diff for typedef-property + export assignment emission changes under CJS export assignment. |
Copilot's findings
- Files reviewed: 2/17 changed files
- Comments generated: 0
jakebailey
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @weswigham's review, these diffs are non-concerning — the namespace merge is no longer needed since typedefs can now be exported at the top level alongside
export=, and the_exports→_defaultlocal name change is nonfunctional.submoduleTriagedtosubmoduleAcceptedsubmoduleTriaged.txt