Skip to content

Accept CJS module.exports = {} baseline diffs #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanCavanaugh merged 2 commits into from
May 15, 2026
Merged

Accept CJS module.exports = {} baseline diffs #3855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaaefe9
Initial plan
Copilot May 15, 2026
ab15fda
Accept CJS `module.exports = {}` baseline diffs (export = _default wi…
Copilot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...eclarationEmitExportAssignedArray.js.diff → ...eclarationEmitExportAssignedArray.js.diff
View file
Open in desktop
File renamed without changes.
0 ...dFunctionWithExtraTypedefsMembers.js.diff → ...dFunctionWithExtraTypedefsMembers.js.diff
View file
Open in desktop
File renamed without changes.
0 ...sDeclarationsCommonjsRelativePath.js.diff → ...sDeclarationsCommonjsRelativePath.js.diff
View file
Open in desktop
File renamed without changes.
0 ...ocCommentsOnConsts(target=es2015).js.diff → ...ocCommentsOnConsts(target=es2015).js.diff
View file
Open in desktop
File renamed without changes.
0 ...ssionPlusSecondary(target=es2015).js.diff → ...ssionPlusSecondary(target=es2015).js.diff
View file
Open in desktop
File renamed without changes.
0 ...entWithKeywordName(target=es2015).js.diff → ...entWithKeywordName(target=es2015).js.diff
View file
Open in desktop
File renamed without changes.
0 ...sDeclarationsExportedClassAliases.js.diff → ...sDeclarationsExportedClassAliases.js.diff
View file
Open in desktop
File renamed without changes.
0 ...ortAliasExposedWithinNamespaceCjs.js.diff → ...ortAliasExposedWithinNamespaceCjs.js.diff
View file
Open in desktop
File renamed without changes.
0 ...ReexportedCjsAlias(target=es2015).js.diff → ...ReexportedCjsAlias(target=es2015).js.diff
View file
Open in desktop
File renamed without changes.
0 ...ReferenceToClassInstanceCrossFile.js.diff → ...ReferenceToClassInstanceCrossFile.js.diff
View file
Open in desktop
File renamed without changes.
0 ...ormance/jsDeclarationsTypeAliases.js.diff → ...ormance/jsDeclarationsTypeAliases.js.diff
View file
Open in desktop
File renamed without changes.
0 ...ionsTypeReferences(target=es2015).js.diff → ...ionsTypeReferences(target=es2015).js.diff
View file
Open in desktop
File renamed without changes.
0 ...onsTypeReferences2(target=es2015).js.diff → ...onsTypeReferences2(target=es2015).js.diff
View file
Open in desktop
File renamed without changes.
0 ...DeclarationsTypedefAndImportTypes.js.diff → ...DeclarationsTypedefAndImportTypes.js.diff
View file
Open in desktop
File renamed without changes.
0 ...ypedefPropertyAndExportAssignment.js.diff → ...ypedefPropertyAndExportAssignment.js.diff
View file
Open in desktop
File renamed without changes.
18 changes: 18 additions & 0 deletions testdata/submoduleAccepted.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,6 +1382,24 @@ conformance/moduleExportDuplicateAlias2.js.diff
conformance/moduleExportDuplicateAlias3.js.diff
conformance/moduleExportsElementAccessAssignment.js.diff

# CJS `module.exports = {}` now emits `export = _default` with inlined object type instead of named exports
## https://github.com/microsoft/typescript-go/issues/3543
compiler/jsDeclarationEmitExportAssignedArray.js.diff
compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff
conformance/jsDeclarationsCommonjsRelativePath.js.diff
conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff
conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff
conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff
conformance/jsDeclarationsExportedClassAliases.js.diff
conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff
conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff
conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff
conformance/jsDeclarationsTypeAliases.js.diff
conformance/jsDeclarationsTypeReferences(target=es2015).js.diff
conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff
conformance/jsDeclarationsTypedefAndImportTypes.js.diff
conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff

# @overload handling changes in JS declaration emit (we no longer support @overload on declarations that can't have TS overloads)
## https://github.com/microsoft/typescript-go/issues/3555
compiler/jsFileAlternativeUseOfOverloadTag.js.diff
Expand Down
18 changes: 0 additions & 18 deletions testdata/submoduleTriaged.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,24 +47,6 @@ conformance/nodeModulesAllowJsImportAssignment(module=node18).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=node20).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=nodenext).js.diff

# CJS `module.exports = {}` now emits `export = _default` with inlined object type instead of named exports
## https://github.com/microsoft/typescript-go/issues/3543
compiler/jsDeclarationEmitExportAssignedArray.js.diff
compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff
conformance/jsDeclarationsCommonjsRelativePath.js.diff
conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff
conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff
conformance/jsDeclarationsExportedClassAliases.js.diff
conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff
conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff
conformance/jsDeclarationsTypeReferences(target=es2015).js.diff
conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff
conformance/jsDeclarationsTypeAliases.js.diff
conformance/jsDeclarationsTypedefAndImportTypes.js.diff
conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff
conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff
conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff

# CJS class expression exports now emit anonymous constructor types instead of named class declarations
## https://github.com/microsoft/typescript-go/issues/3544
conformance/commonJSImportExportedClassExpression.js.diff
Expand Down
Loading