fix(declarations): prevent panic for KindArrowFunction parameter visibility - #4638
Closed
kimyeongrae23 wants to merge 1 commit into
Closed
fix(declarations): prevent panic for KindArrowFunction parameter visibility#4638kimyeongrae23 wants to merge 1 commit into
kimyeongrae23 wants to merge 1 commit into
Conversation
…n for parameter visibility
kimyeongrae23
force-pushed
the
fix/issue-4629-arrow-function-panic
branch
from
July 14, 2026 17:26
3356e8b to
27686f4
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4629
Problem
getParameterDeclarationTypeVisibilityDiagnosticMessagepanics with"Unknown parent for parameter: KindArrowFunction"when declaration emit encounters an arrow function parameter whose type references an unnameable symbol.Root cause
The switch on
node.Parent.Kindhandles many parent kinds (Constructor, MethodDeclaration, FunctionDeclaration, etc.) but missesKindArrowFunctionandKindFunctionExpression.Fix
Add
ast.KindArrowFunctionandast.KindFunctionExpressionto the function-like case, reusing the existing "exported function" parameter diagnostic message — consistent with howKindFunctionDeclarationandKindFunctionTypeare handled.Change
internal/transformers/declarations/diagnostics.go: add missingKindArrowFunctionandKindFunctionExpressionto theKindFunctionDeclaration, KindFunctionTypecase.