Recognize jsxImportSource namespaces in checked JavaScript - #4694
Merged
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix JSX namespace recognition issue for JS files
Recognize jsxImportSource namespaces in checked JavaScript
Jul 21, 2026
jakebailey
approved these changes
Jul 21, 2026
jakebailey
left a comment
Member
There was a problem hiding this comment.
Ah yes, the classic "JS is actually JSX" thing
RyanCavanaugh
approved these changes
Jul 21, 2026
jakebailey
enabled auto-merge
July 21, 2026 17:54
Contributor
There was a problem hiding this comment.
Pull request overview
Extends JSX runtime namespace resolution to checked JavaScript files.
Changes:
- Synthesizes JSX runtime imports for
.jsand.jsxfiles. - Adds compiler coverage with type and symbol baselines.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/compiler/fileloader.go |
Includes JavaScript files in JSX runtime import resolution. |
testdata/tests/cases/compiler/jsxImportSourceCheckJs.ts |
Adds the regression test. |
testdata/baselines/reference/compiler/jsxImportSourceCheckJs.types |
Verifies resolved JSX element types. |
testdata/baselines/reference/compiler/jsxImportSourceCheckJs.symbols |
Verifies intrinsic element symbol resolution. |
|
Awesome, thanks 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked
.jsfiles usingjsxImportSourcefailed to resolve the runtime module’sJSXnamespace, while equivalent.tsxfiles worked.Root cause
.jsfiles.Change
JSX.IntrinsicElementsresolves frompreact/jsx-runtime.