[api] Move language service methods into dedicated namespace - #4893
Merged
Andrew Branch (andrewbranch) merged 2 commits intoAug 13, 2026
Merged
Conversation
| @@ -1,4 +1,3 @@ | |||
| /// <reference path="../node/node.ts" preserve="true" /> | |||
Member
Author
There was a problem hiding this comment.
Drive-by: at one point node.ts performed module augmentation, but that’s been gone for a while, so this is no longer needed.
Copilot started reviewing on behalf of
Andrew Branch (andrewbranch)
August 13, 2026 16:10
View session
Member
Author
|
navya9singh Piotr Tomiak (@piotrtomiak), methods you rely on are moving. I left deprecated aliases in for use in nightlies for now, but will be removed before the 7.1 release. |
Contributor
There was a problem hiding this comment.
Pull request overview
Groups language-service APIs under Project.languageService, preparing APIs for Programs without LanguageServices while retaining deprecated compatibility methods.
Changes:
- Adds sync/async
LanguageServicenamespaces and migrates tests. - Keeps deprecated forwarding methods.
- Extracts JSDoc rendering from the language service.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/ls/jsdoc.go |
Removes language-service JSDoc helpers. |
internal/jsdoc/jsdoc.go |
Adds standalone JSDoc extraction and rendering. |
internal/api/session.go |
Uses standalone JSDoc helpers. |
_packages/native-preview/src/api/async/api.ts |
Adds the async language-service namespace. |
_packages/native-preview/src/api/sync/api.ts |
Adds the generated sync namespace. |
_packages/native-preview/src/api/async/types.ts |
Updates async API documentation links. |
_packages/native-preview/src/api/sync/types.ts |
Updates sync API documentation links. |
_packages/native-preview/test/async/api.test.ts |
Migrates async language-service tests. |
_packages/native-preview/test/sync/api.test.ts |
Migrates sync language-service tests. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Andrew Branch (andrewbranch)
August 13, 2026 18:09
View session
Andrew Branch (andrewbranch)
requested review from
Gabriela Araujo Britto (gabritto) and
navya9singh
August 13, 2026 18:22
Gabriela Araujo Britto (gabritto)
approved these changes
Aug 13, 2026
Jake Bailey (jakebailey)
pushed a commit
to jakebailey/TypeScript
that referenced
this pull request
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I always intended these methods to be grouped (I think some of them were at one point but a merge conflict resolution lost it?), but this will be more important as some features from #4830 expose Programs without LanguageServices.