[http-client-csharp] `SystemObjectTypeProvider` looks unnecessary

[ArcturusZhang]

We introduced SystemObjectTypeProvider to represent any type written in custom code.
But NamedSymbolTypeProvider is doing the same thing, do we really need both?

Also in the BaseType resolution logic in ModelProvider, we have 3 different methods:
BuildBaseType (BaseType), BuildBaseTypeProvider (BaseTypeProvider) and BuildBaseModelProvider (BaseModelProvider)
they do not really agree with each other.
BuildBaseTypeProvider builds another instance (instantiating SystemObjectTypeProvider) instead of just returning whatever returned by BaseModelProvider.

I think we should figure out and make them consistent.

[github-actions]

🎯 Issue Triage

This is a code cleanup/refactoring request in the http-client-csharp generator to eliminate redundancy between SystemObjectTypeProvider and NamedSymbolTypeProvider, and to reconcile the inconsistent BuildBaseType/BuildBaseTypeProvider/BuildBaseModelProvider methods in ModelProvider.

Category: Feature Request
Area: emitter:client:csharp

🔍 Analysis

• SystemObjectTypeProvider and NamedSymbolTypeProvider apparently overlap in purpose — both represent types from custom/system code.
• In ModelProvider, three base-type resolution methods (BuildBaseType, BuildBaseTypeProvider, BuildBaseModelProvider) are inconsistent: BuildBaseTypeProvider instantiates a new SystemObjectTypeProvider instead of delegating to BuildBaseModelProvider.
• This inconsistency could lead to subtle bugs or divergent behavior depending on which method is called.
• Affected file: packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/SystemObjectTypeProvider.cs and ModelProvider.

📝 Suggested next steps

• Determine whether SystemObjectTypeProvider or NamedSymbolTypeProvider should be the canonical representation for system/custom-code types and remove (or alias) the other.
• Unify BuildBaseType, BuildBaseTypeProvider, and BuildBaseModelProvider so they are consistent — likely by having BuildBaseTypeProvider return the result from BuildBaseModelProvider rather than constructing a new instance.
• Add or update unit tests to cover the base type resolution path.

Generated by Agentic Triage