fix: IDE completion no longer wraps allowed keyword identifiers in backticks - #11426
Merged
Timothee Guerin (timotheeguerin) merged 2 commits intoJul 28, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
…positions Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix IDE completion to avoid wrapping keywords in quotes
fix: IDE completion no longer wraps allowed keyword identifiers in backticks
Jul 28, 2026
commit: |
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
July 28, 2026 19:30
|
You can try these changes here
|
Mark Cowlishaw (markcowl)
approved these changes
Jul 28, 2026
Timothee Guerin (timotheeguerin)
deleted the
copilot/fix-ide-completion-keywords
branch
July 28, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When completing keyword identifiers (e.g.
auto,internal,extern) in positions where they are valid without escaping — model property names, object literal properties, and member expressions — the language server was incorrectly inserting backtick-quoted completions.Changes
completion.ts— AddedgetIdentifierPrintContext()helper that returns"allow-reserved"when the identifier node's parent is aMemberExpression,ModelProperty, orObjectLiteralProperty, and"disallow-reserved"otherwise. UpdatedaddIdentifierCompletionto pass this context toprintIdentifierinstead of always using the default ("disallow-reserved").completion.test.ts— Two new tests covering keyword completion without backticks in member expression and model body contexts.