Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/compiler/src/core/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5254,6 +5254,16 @@ export function createChecker(program: Program, resolver: NameResolver): Checker
parentModel,
);

if (isArrayModelType(parentModel) && (newProperties.length > 0 || additionalIndexer !== undefined)) {
reportCheckerDiagnostic(
createDiagnostic({
code: "no-array-properties",
target: prop.target,
}),
);
continue;
}

if (additionalIndexer) {
if (spreadIndexers) {
spreadIndexers.push(additionalIndexer);
Expand Down
28 changes: 28 additions & 0 deletions packages/compiler/test/checker/model.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,34 @@ describe("with is", () => {
});
});

it("model is array cannot spread record properties", async () => {
const diagnostics = await Tester.diagnose(`
model A is Array<string> {
...Record<int32>;
}
`);
expectDiagnostics(diagnostics, {
code: "no-array-properties",
message: "Array models cannot have any properties.",
});
});

it("model extends array cannot spread model properties", async () => {
const diagnostics = await Tester.diagnose(`
model Source {
name: string;
}

model A extends Array<string> {
...Source;
}
`);
expectDiagnostics(diagnostics, {
code: "no-array-properties",
message: "Array models cannot have any properties.",
});
});

it("doesn't allow duplicate properties", async () => {
const diagnostics = await Tester.diagnose(`
model A { x: int32 }
Expand Down