[http-client-java] Continue after constant response headers - #11793
Merged
Weidong Xu (weidongxu-microsoft) merged 1 commit intoAug 31, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bb07cf76-b69f-4640-87a7-8660a97e0d23
microsoft-github-policy-service
Bot
added
the
emitter:client:java
Weidong Xu (weidongxu-microsoft)
marked this pull request as ready for review
August 31, 2026 05:46
Weidong Xu (weidongxu-microsoft)
requested a review
from Haoling Dong (haolingdong-msft)
as a code owner
August 31, 2026 05:46
Weidong Xu (weidongxu-microsoft)
requested review from
Xiaofei Cao (XiaofeiCao),
Alan Zimmer (alzimmermsft) and
Jesse Squire (jsquire)
as code owners
August 31, 2026 05:46
Copilot started reviewing on behalf of
Weidong Xu (weidongxu-microsoft)
August 31, 2026 05:47
View session
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Java emitter’s response-header collection logic so that encountering a constant response header no longer stops processing subsequent headers, while also limiting the “constant header removed” warning suppression to Content-Type. It also extends the existing response-headers TypeSpec test input to include a constant response header as a regression case.
Changes:
- Continue iterating through response headers after omitting a constant header (use
continueinstead of exiting the loop). - Emit the
constant-header-in-response-removedwarning for constant response headers exceptContent-Type. - Add a constant response header to the response-headers generator test scenario, plus a Chronus fix entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/http-client-java/generator/http-client-generator-test/tsp/response-headers.tsp | Adds a constant response header to validate it’s omitted without affecting subsequent generated headers. |
| packages/http-client-java/emitter/src/code-model-builder.ts | Fixes response header processing to skip constant headers but keep processing the rest; suppresses warning only for Content-Type. |
| .chronus/changes/fix-java-response-constant-header-2026-08-31.md | Adds changelog entry describing the fix for constant response headers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Xiaofei Cao (XiaofeiCao)
approved these changes
Aug 31, 2026
|
You can try these changes here
|
Weidong Xu (weidongxu-microsoft)
deleted the
fix/java-response-constant-header
branch
August 31, 2026 07:27
Weidong Xu (weidongxu-microsoft)
added a commit
to Azure/typespec-azure
that referenced
this pull request
Aug 31, 2026
## Summary - bump `@azure-tools/typespec-java` from `0.46.0` to `0.46.1` - publish the Java fixes synced in #5239 ## Included fixes - management `remove-model` generation (`microsoft/typespec#11698`) - Javadocs containing `*/` (`microsoft/typespec#11766`) - response headers following a constant header (`microsoft/typespec#11793`) --------- Copilot-Session: 0c853adf-d456-4d99-bacc-fd941aca7924
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-TypeValidation
npm run buildnpm run formatpnpm formatpnpm exec oxlint packages/http-client-java/emitter --type-aware --deny-warningsnpm run test:emittermvn test --define "test=tsptest.responseheaders.ResponseHeadersTests" --no-transfer-progress