Consolidate template checking by providing helpers in the compiler - #769
Merged
Timothee Guerin (timotheeguerin) merged 3 commits intoJul 26, 2022
Merged
Conversation
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/769/ |
Nick Guerrera (nguerrera)
approved these changes
Jul 26, 2022
Brian Terlson (bterlson)
approved these changes
Jul 26, 2022
| /** | ||
| * Resolve if the model is a template type(Non initialized template type). | ||
| */ | ||
| export function isTemplate(model: ModelType): boolean { |
Contributor
There was a problem hiding this comment.
Missed that we made a breaking change here, but it shows up on flow to cadl-azure. The new isTemplate checks for declaration or instance.
I'd be tempted to change the new isTemplate to isTemplateDeclarationOrInstance so that we can't get confused. To me at least, a template instance is not really a template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #601