fix mock NMR deregister race. - #319
Merged
Shankar Seal (shankarseal) merged 3 commits intoAug 11, 2026
Merged
Conversation
Shankar Seal (shankarseal)
requested review from
Alan Jowett (Alan-Jowett) and
Michael Friesen (mtfriesen)
as code owners
August 1, 2026 08:20
Shankar Seal (shankarseal)
force-pushed
the
shankarseal-fix-nmr-deregister-race
branch
from
August 3, 2026 08:52
2d4b365 to
7d63080
Compare
Shankar Seal (shankarseal)
force-pushed
the
shankarseal-fix-nmr-deregister-race
branch
from
August 5, 2026 23:26
7d63080 to
d87efd1
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6e257781-cd5a-4ae3-9943-0c217ccad54e
Shankar Seal (shankarseal)
force-pushed
the
shankarseal-fix-nmr-deregister-race
branch
from
August 11, 2026 03:29
9fd7c6d to
8582087
Compare
Alan Jowett (Alan-Jowett)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #318 an NMR client deregister can race with an incomplete NMR provider registration.
STATUS_PENDING, matching Windows NMR behavior.LateBindand unbound immediately.pending_bind_opstracks accepted attach operations that have not completed. Each module also tracks all successfully attached bindings.Testing