[llfio,outcome,status-code,ned14-internal-quickcpplib] Update to 2026-04-29#51455
Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom Apr 30, 2026
Merged
Conversation
BillyONeal
requested changes
Apr 30, 2026
Member
BillyONeal
left a comment
There was a problem hiding this comment.
These appear to be legitimate.
There are some feature test problems!
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core]:x64-android build failed but was expected to pass
note: consider adding `llfio=fail`, or `llfio:x64-android=fail`, or equivalent skips
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,run-tests]:x64-android build failed but was expected to pass
note: if llfio[run-tests] succeeds when built with other features but not alone, consider adding `llfio[core,run-tests]:x64-android=combination-fails`
note: if llfio[run-tests] always fails, consider adding `llfio[run-tests]:x64-android=feature-fails`, which will mark this test as failing, and remove llfio[run-tests] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,status-code]:x64-android build failed but was expected to pass
note: if llfio[status-code] succeeds when built with other features but not alone, consider adding `llfio[core,status-code]:x64-android=combination-fails`
note: if llfio[status-code] always fails, consider adding `llfio[status-code]:x64-android=feature-fails`, which will mark this test as failing, and remove llfio[status-code] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx20]:x64-android build failed but was expected to pass
note: if llfio[polyfill-cxx20] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx20]:x64-android=combination-fails`
note: if llfio[polyfill-cxx20] always fails, consider adding `llfio[polyfill-cxx20]:x64-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx20] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17]:x64-android build failed but was expected to pass
note: if llfio[polyfill-cxx17] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx17]:x64-android=combination-fails`
note: if llfio[polyfill-cxx17] always fails, consider adding `llfio[polyfill-cxx17]:x64-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx17] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:x64-android build failed but was expected to pass
note: consider adding `llfio=fail`, `llfio:x64-android=fail`, `llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:x64-android=combination-fails`, or equivalent skips, or by marking mutually exclusive features as options
There are some feature test problems!
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx20]:arm-neon-android build failed but was expected to pass
note: if llfio[polyfill-cxx20] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx20]:arm-neon-android=combination-fails`
note: if llfio[polyfill-cxx20] always fails, consider adding `llfio[polyfill-cxx20]:arm-neon-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx20] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17]:arm-neon-android build failed but was expected to pass
note: if llfio[polyfill-cxx17] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx17]:arm-neon-android=combination-fails`
note: if llfio[polyfill-cxx17] always fails, consider adding `llfio[polyfill-cxx17]:arm-neon-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx17] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:arm-neon-android build failed but was expected to pass
note: consider adding `llfio=fail`, `llfio:arm-neon-android=fail`, `llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:arm-neon-android=combination-fails`, or equivalent skips, or by marking mutually exclusive features as options
There are some feature test problems!
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx20]:arm64-android build failed but was expected to pass
note: if llfio[polyfill-cxx20] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx20]:arm64-android=combination-fails`
note: if llfio[polyfill-cxx20] always fails, consider adding `llfio[polyfill-cxx20]:arm64-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx20] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17]:arm64-android build failed but was expected to pass
note: if llfio[polyfill-cxx17] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx17]:arm64-android=combination-fails`
note: if llfio[polyfill-cxx17] always fails, consider adding `llfio[polyfill-cxx17]:arm64-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx17] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:arm64-android build failed but was expected to pass
note: consider adding `llfio=fail`, `llfio:arm64-android=fail`, `llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:arm64-android=combination-fails`, or equivalent skips, or by marking mutually exclusive features as options
4e51090 to
8a1eba6
Compare
* Disable android support for polyfill-cxx20, because the `char8_t` polyfill is not compatible with the Android NDK's stdlib. * Properly set `CMAKE_CXX_STANDARD` for all feature combinations * Remove `polyfill-cxx17` feature as upstream removed C++17 polyfills * Remove `LLFIO_FORCE_OPENSSL_OFF` option as upstream removed it
744a6f3 to
752dc94
Compare
Contributor
Author
Indeed C++17
|
BillyONeal
reviewed
Apr 30, 2026
| @@ -1,8 +1,7 @@ | |||
| diff --git a/cmake/headers.cmake b/cmake/headers.cmake | |||
| index 734e7d0..5d0f646 100644 | |||
| --- a/cmake/headers.cmake | |||
Member
There was a problem hiding this comment.
Can you submit this to https://github.com/ned14/outcome ?
Contributor
Author
There was a problem hiding this comment.
On upstream these files do exist in git submodules and only on our end we get these files from separate ports which is a bit unfortunate :/
Member
There was a problem hiding this comment.
That we succeed in building without them suggests that they don't need to be here though. Or if one wants them to show up in an IDE or something they can be guarded for an existence check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to bundle these port updates together, because the
status-codeupdate introduced breaking changes../vcpkg x-add-version --alland committing the result.