Skip to content

[llfio,outcome,status-code,ned14-internal-quickcpplib] Update to 2026-04-29#51455

Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom
BurningEnlightenment:dev/llfio/update-2026-04-29
Apr 30, 2026
Merged

[llfio,outcome,status-code,ned14-internal-quickcpplib] Update to 2026-04-29#51455
BillyONeal merged 5 commits intomicrosoft:masterfrom
BurningEnlightenment:dev/llfio/update-2026-04-29

Conversation

@BurningEnlightenment
Copy link
Copy Markdown
Contributor

I had to bundle these port updates together, because the status-code update introduced breaking changes.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These appear to be legitimate.

There are some feature test problems!
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core]:x64-android build failed but was expected to pass
note: consider adding `llfio=fail`, or `llfio:x64-android=fail`, or equivalent skips
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,run-tests]:x64-android build failed but was expected to pass
note: if llfio[run-tests] succeeds when built with other features but not alone, consider adding `llfio[core,run-tests]:x64-android=combination-fails`
note: if llfio[run-tests] always fails, consider adding `llfio[run-tests]:x64-android=feature-fails`, which will mark this test as failing, and remove llfio[run-tests] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,status-code]:x64-android build failed but was expected to pass
note: if llfio[status-code] succeeds when built with other features but not alone, consider adding `llfio[core,status-code]:x64-android=combination-fails`
note: if llfio[status-code] always fails, consider adding `llfio[status-code]:x64-android=feature-fails`, which will mark this test as failing, and remove llfio[status-code] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx20]:x64-android build failed but was expected to pass
note: if llfio[polyfill-cxx20] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx20]:x64-android=combination-fails`
note: if llfio[polyfill-cxx20] always fails, consider adding `llfio[polyfill-cxx20]:x64-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx20] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17]:x64-android build failed but was expected to pass
note: if llfio[polyfill-cxx17] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx17]:x64-android=combination-fails`
note: if llfio[polyfill-cxx17] always fails, consider adding `llfio[polyfill-cxx17]:x64-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx17] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:x64-android build failed but was expected to pass
note: consider adding `llfio=fail`, `llfio:x64-android=fail`, `llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:x64-android=combination-fails`, or equivalent skips, or by marking mutually exclusive features as options
There are some feature test problems!
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx20]:arm-neon-android build failed but was expected to pass
note: if llfio[polyfill-cxx20] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx20]:arm-neon-android=combination-fails`
note: if llfio[polyfill-cxx20] always fails, consider adding `llfio[polyfill-cxx20]:arm-neon-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx20] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17]:arm-neon-android build failed but was expected to pass
note: if llfio[polyfill-cxx17] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx17]:arm-neon-android=combination-fails`
note: if llfio[polyfill-cxx17] always fails, consider adding `llfio[polyfill-cxx17]:arm-neon-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx17] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:arm-neon-android build failed but was expected to pass
note: consider adding `llfio=fail`, `llfio:arm-neon-android=fail`, `llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:arm-neon-android=combination-fails`, or equivalent skips, or by marking mutually exclusive features as options
There are some feature test problems!
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx20]:arm64-android build failed but was expected to pass
note: if llfio[polyfill-cxx20] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx20]:arm64-android=combination-fails`
note: if llfio[polyfill-cxx20] always fails, consider adding `llfio[polyfill-cxx20]:arm64-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx20] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17]:arm64-android build failed but was expected to pass
note: if llfio[polyfill-cxx17] succeeds when built with other features but not alone, consider adding `llfio[core,polyfill-cxx17]:arm64-android=combination-fails`
note: if llfio[polyfill-cxx17] always fails, consider adding `llfio[polyfill-cxx17]:arm64-android=feature-fails`, which will mark this test as failing, and remove llfio[polyfill-cxx17] from combined feature testing
note: if some features are required, consider effectively always enabling those parts in portfile.cmake for llfio, or consider adding `llfio[required-feature]=options` to include 'required-feature' in all tests
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt: error: llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:arm64-android build failed but was expected to pass
note: consider adding `llfio=fail`, `llfio:arm64-android=fail`, `llfio[core,polyfill-cxx17,polyfill-cxx20,run-tests,status-code]:arm64-android=combination-fails`, or equivalent skips, or by marking mutually exclusive features as options

@BillyONeal BillyONeal marked this pull request as draft April 30, 2026 00:04
@BurningEnlightenment BurningEnlightenment force-pushed the dev/llfio/update-2026-04-29 branch from 4e51090 to 8a1eba6 Compare April 30, 2026 07:42
* Disable android support for polyfill-cxx20, because the `char8_t`
  polyfill is not compatible with the Android NDK's stdlib.
* Properly set `CMAKE_CXX_STANDARD` for all feature combinations
* Remove `polyfill-cxx17` feature as upstream removed C++17 polyfills
* Remove `LLFIO_FORCE_OPENSSL_OFF` option as upstream removed it
@BurningEnlightenment BurningEnlightenment force-pushed the dev/llfio/update-2026-04-29 branch from 744a6f3 to 752dc94 Compare April 30, 2026 10:04
@BurningEnlightenment BurningEnlightenment marked this pull request as ready for review April 30, 2026 14:25
@BurningEnlightenment
Copy link
Copy Markdown
Contributor Author

These appear to be legitimate.

Indeed C++17 <filesystem> detection needs a hand when cross-compiling. I also cleaned some other cruft:

  • Disable android support for polyfill-cxx20, because the char8_t
    polyfill is not compatible with the Android NDK's stdlib.
  • Properly set CMAKE_CXX_STANDARD for all feature combinations
  • Remove polyfill-cxx17 feature as upstream removed C++17 polyfills
  • Remove LLFIO_FORCE_OPENSSL_OFF option as upstream removed it

@@ -1,8 +1,7 @@
diff --git a/cmake/headers.cmake b/cmake/headers.cmake
index 734e7d0..5d0f646 100644
--- a/cmake/headers.cmake
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit this to https://github.com/ned14/outcome ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On upstream these files do exist in git submodules and only on our end we get these files from separate ports which is a bit unfortunate :/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That we succeed in building without them suggests that they don't need to be here though. Or if one wants them to show up in an IDE or something they can be guarded for an existence check.

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BillyONeal BillyONeal merged commit aa173a9 into microsoft:master Apr 30, 2026
16 checks passed
@BurningEnlightenment BurningEnlightenment deleted the dev/llfio/update-2026-04-29 branch April 30, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants