Skip to content

Update ThirdPartyNotices.txt - #14611

Merged
sean-mcmanus merged 2 commits into
mainfrom
seanmcm/updateThirdPartyNotices
Jul 27, 2026
Merged

Update ThirdPartyNotices.txt#14611
sean-mcmanus merged 2 commits into
mainfrom
seanmcm/updateThirdPartyNotices

Conversation

@sean-mcmanus

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the extension’s third-party attributions by modifying ThirdPartyNotices.txt, including adding new entries and removing/reordering existing ones.

Changes:

  • Removes a number of existing third-party notice blocks and restructures the ordering of several adjacent entries.
  • Adds new notice blocks for tas-client and vscode-tas-client.
  • Adjusts formatting/content of some MIT license text blocks (including quote characters).
Comments suppressed due to low confidence (5)

Extension/ThirdPartyNotices.txt:1369

  • This update removes several dependency notices that still appear in the Extension dependency graph, leaving ThirdPartyNotices incomplete. For example, asynckit@^0.4.0 is still in Extension/yarn.lock (around lines 1612-1615), but there is no asynckit entry anywhere in this file anymore; similarly combined-stream@^1.0.8 (yarn.lock ~2025-2031) and its dependency delayed-stream@~1.0.0 (yarn.lock ~2254-2257) are still present but have no notices here. Please regenerate ThirdPartyNotices from the current Extension/yarn.lock (or add back notices for the still-present packages such as asynckit/combined-stream/delayed-stream/dunder-proto/mime-types/mime-db/uuid/call-bind-apply-helpers/etc.).
---------------------------------------------------------

---------------------------------------------------------

balanced-match 1.0.2 - MIT

Extension/ThirdPartyNotices.txt:2882

  • This new vscode-tas-client notice is missing the project URL line; other entries include one and it helps trace the source. Consider adding the repo/homepage URL (e.g. https://github.com/microsoft/tas-client).
vscode-tas-client 0.1.84 - MIT


MIT License

Extension/ThirdPartyNotices.txt:1607

  • This license line uses curly quotes around “AS IS”. Most MIT entries in this file use straight ASCII quotes; normalizing this helps keep license text consistent and avoids encoding surprises.
THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

Extension/ThirdPartyNotices.txt:1721

  • This MIT license grant line uses curly quotes in “Software”. Elsewhere in the file MIT notices use straight quotes; normalizing reduces encoding inconsistencies.
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

Extension/ThirdPartyNotices.txt:1725

  • This MIT disclaimer line uses curly quotes around “AS IS”. Most other MIT notices in this file use straight quotes; normalizing avoids inconsistent encoding.
THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Extension/ThirdPartyNotices.txt
Comment thread Extension/ThirdPartyNotices.txt
Colengms
Colengms previously approved these changes Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (10)

Extension/ThirdPartyNotices.txt:1369

  • The asynckit third-party notice was removed, but asynckit@^0.4.0 is still present in Extension/yarn.lock (see Extension/yarn.lock:1612). If the extension still ships this dependency, its license text needs to remain in ThirdPartyNotices.txt for compliance.

Recommendation: restore the asynckit 0.4.0 notice block (from the prior file version) or regenerate ThirdPartyNotices.txt from the current dependency graph so asynckit is included.

This issue also appears in the following locations of the same file:

  • line 1486
  • line 1518
  • line 1587
  • line 1707
  • line 1732
  • ...and 3 more
---------------------------------------------------------

---------------------------------------------------------

balanced-match 1.0.2 - MIT

Extension/ThirdPartyNotices.txt:1522

  • This section replaced call-bind-apply-helpers with a second brace-expansion entry, but call-bind-apply-helpers@^1.0.x is still present in Extension/yarn.lock (Extension/yarn.lock:1827) and the notice no longer appears anywhere in ThirdPartyNotices.txt.

Recommendation: restore the call-bind-apply-helpers notice block (or regenerate notices from the lockfile) so this dependency remains covered.

---------------------------------------------------------

---------------------------------------------------------

brace-expansion 2.1.2 - MIT

Extension/ThirdPartyNotices.txt:1591

  • The combined-stream notice appears to have been removed (no occurrences remain in ThirdPartyNotices.txt), but combined-stream@^1.0.8 is still present in Extension/yarn.lock (Extension/yarn.lock:2025).

Recommendation: add back the combined-stream license notice (or regenerate ThirdPartyNotices.txt) to keep third-party attributions complete.

chokidar 3.6.0 - MIT
https://github.com/paulmillr/chokidar

(c) Paul Miller
Copyright (c) 2012-2019 Paul Miller (https://paulmillr.com), Elan Shanker

Extension/ThirdPartyNotices.txt:1711

  • The delayed-stream and dunder-proto notices were removed, but both packages are still present in Extension/yarn.lock (delayed-stream: Extension/yarn.lock:2254, dunder-proto: Extension/yarn.lock:2326). Neither package name appears anywhere in the updated ThirdPartyNotices.txt.

Recommendation: restore these notice blocks (or regenerate the notices from the current lockfile) so shipped transitive dependencies remain attributed.

---------------------------------------------------------

---------------------------------------------------------

emojis-list 3.0.0 - MIT

Extension/ThirdPartyNotices.txt:1736

  • Several third-party notices removed in this update still correspond to packages present in Extension/yarn.lock, and they no longer appear anywhere in ThirdPartyNotices.txt: es-define-property (Extension/yarn.lock:2500), es-errors (:2505), get-intrinsic (:3156), get-proto (:3172), and gopd (:3335).

Recommendation: restore the missing notice blocks or regenerate ThirdPartyNotices.txt from the current lockfile so these dependencies remain covered.

escape-string-regexp 2.0.0 - MIT
https://github.com/sindresorhus/escape-string-regexp#readme

(c) Sindre Sorhus (https://sindresorhus.com)
Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (sindresorhus.com)

Extension/ThirdPartyNotices.txt:1789

  • The has-symbols and has-tostringtag notices were removed, but both packages are still present in Extension/yarn.lock (has-symbols: Extension/yarn.lock:3451, has-tostringtag: Extension/yarn.lock:3456), and neither appears anywhere in ThirdPartyNotices.txt.

Recommendation: restore these notice blocks (or regenerate notices from the lockfile) to keep third-party attributions complete.

fill-range 7.1.1 - MIT
https://github.com/jonschlinkert/fill-range

Copyright (c) 2014-present, Jon Schlinkert
Copyright (c) 2019, Jon Schlinkert (https://github.com/jonschlinkert)

Extension/ThirdPartyNotices.txt:2039

  • The math-intrinsics notice was removed, but math-intrinsics@^1.1.0 is still present in Extension/yarn.lock (Extension/yarn.lock:4317), and math-intrinsics no longer appears anywhere in ThirdPartyNotices.txt.

Recommendation: restore the math-intrinsics notice block (or regenerate notices from the lockfile) so this dependency remains attributed.

---------------------------------------------------------

---------------------------------------------------------

merge2 1.4.1 - MIT

Extension/ThirdPartyNotices.txt:2106

  • The mime-db and mime-types notices were removed, but both are still present in Extension/yarn.lock (mime-db: Extension/yarn.lock:4364, mime-types: Extension/yarn.lock:4369), and neither name appears anywhere in the updated ThirdPartyNotices.txt.

Recommendation: restore the notice blocks for both packages (or regenerate ThirdPartyNotices.txt from the lockfile) to keep third-party notices complete.

---------------------------------------------------------

---------------------------------------------------------

mkdirp 3.0.1 - MIT
https://github.com/isaacs/node-mkdirp#readme

Extension/ThirdPartyNotices.txt:2762

  • The uuid notice was removed entirely, but uuid is still a direct dependency in Extension/package.json ("uuid": "^11.1.1" at Extension/package.json:7266) and is present in Extension/yarn.lock (Extension/yarn.lock:6302). uuid no longer appears anywhere in ThirdPartyNotices.txt.

Recommendation: add back a uuid notice entry for the version currently used (11.1.1 per yarn.lock), including the full MIT license text, to keep notices accurate and complete.

---------------------------------------------------------

---------------------------------------------------------

vscode-jsonrpc 8.2.0 - MIT

Extension/ThirdPartyNotices.txt:1490

  • Extension/yarn.lock includes an additional brace-expansion version that still appears to be in the dependency graph (brace-expansion@^5.0.2 -> version 5.0.8 at Extension/yarn.lock:1747), but ThirdPartyNotices.txt only includes brace-expansion 1.1.16 and 2.1.2.

Recommendation: add a notice entry for brace-expansion 5.0.8 as well (or regenerate the notices from the lockfile) so all shipped versions are covered.

---------------------------------------------------------

---------------------------------------------------------

brace-expansion 1.1.16 - MIT

@sean-mcmanus
sean-mcmanus merged commit 0f754f7 into main Jul 27, 2026
7 checks passed
@sean-mcmanus
sean-mcmanus deleted the seanmcm/updateThirdPartyNotices branch July 27, 2026 23:00
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants