Skip to content

Fix .vscodeignore missing .gitignore in themes extension - #14636

Merged
sean-mcmanus merged 3 commits into
microsoft:mainfrom
luo2430:fix/Themes
Aug 4, 2026
Merged

Fix .vscodeignore missing .gitignore in themes extension#14636
sean-mcmanus merged 3 commits into
microsoft:mainfrom
luo2430:fix/Themes

Conversation

@luo2430

@luo2430 luo2430 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

Themes/.npmrc exists but is not excluded, so development registry/auth configuration would be packaged into the published extension.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Updates the Themes extension packaging ignore list to avoid shipping development-only files in the published VS Code extension.

Changes:

  • Replaces the package-lock-only ignore block with a broader “development files” block.
  • Adds .gitignore to the Themes extension .vscodeignore.
File summaries
File Description
Themes/.vscodeignore Expands the ignore list for the Themes extension package to exclude additional development files.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread Themes/.vscodeignore
luo2430 and others added 2 commits August 5, 2026 00:31
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sean-mcmanus
sean-mcmanus requested a lite review from Copilot August 4, 2026 16:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The change is small, consistent with VS Code extension packaging behavior, and introduces no functional/runtime code impact.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@sean-mcmanus
sean-mcmanus merged commit 5fd0548 into microsoft:main Aug 4, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants