fix: show non-Java resource toggle in view toolbar - #1078
Merged
Conversation
wenyt (wenytang-ms)
requested review from
Changyong Gong (chagong) and
Jinbo Wang (testforstephen)
as code owners
September 3, 2026 07:26
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent with existing contribution patterns in package.json, and the PR reports successful AutoTest validation for the updated scenario.
Pull request overview
This PR promotes the existing “Show/Hide Non-Java Resources” toggle from the Java Projects view overflow menu into the view title toolbar, using distinct eye / eye-closed icons while keeping the same mutually exclusive when conditions. It also updates the AutoTest plan commentary to reflect that the action is now exercised via the toolbar.
Changes:
- Add codicon-based icons to the
showNonJavaResources/hideNonJavaResourcescontributed commands. - Move the corresponding
view/titlemenu items from the overflow group into thenavigationgroup so they appear on the view title toolbar. - Update the AutoTest plan comments to reflect the direct toolbar action path for the toggle.
File summaries
| File | Description |
|---|---|
| test/e2e-plans/java-dep-view-modes.yaml | Updates test-plan comments to describe the view-title toolbar toggle behavior for Show/Hide Non-Java Resources. |
| package.json | Adds eye / eye-closed icons to the commands and moves the toggle actions into the Java Projects view title toolbar (navigation@40). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Changyong Gong (chagong)
approved these changes
Sep 3, 2026
wenyt (wenytang-ms)
deleted the
fix/promote-non-java-resources-toggle
branch
September 3, 2026 07:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eyeandeye-closedicons while preserving the existing mutually exclusive configuration conditions.Validation
java-dep-view-modes.yamlUI verification
Resources shown: Hide action
Resources hidden: Show action