Do the full review on the comments view : add comments, modify code, navigate, intellisense

[jonathanvila]

I have been struggling to do my normal flow :

CASE A

• I have a PR assigned
• I take a look but I need to navigate the code and have intellisense in the view with the comments and with the side by side diff with master
  -> Now I can only see/add the comments but not navigate and have intellisense in the same view.

CASE B

• I create a PR
• my colleague introduce comments
• I respond with more comments and modify code and push again
  -> Now I can not introduce code changes in the comments view
  -> If I do checkout the PR, it creates a new local branch , so if I add changes to it it will be different than the real branch where I did all the changes

[RMacfarlane]

Hey @jonathanvila

For Case A, there is a way to do this currently, but is perhaps not immediately discoverable. If you open the description page of the PR and click "Checkout", a new view in the sidebar should appear titled "Changes in Pull Request". Here you can browse the diffs as before, or navigate to the file as it is on disk using this button:

You can see and add comments in both the diff and actual file, intellisense/navigation should work in both, and the right hand side of the diff editor should allow editing.

For Case B,

If I do checkout the PR, it creates a new local branch

This is not the expected behavior, it should reuse the branch you already have instead. I'll look into this!

[georgi-denchew]

I had to find this comment from @RMacfarlane in order to find out how I can have the code diff, navigation and IntelliSense in the same view, so it's probably worth making this feature easier to discover from within VS Code or just enable it by default.

[jonathanvila]

@RMacfarlane I have already tried that but I dont see the differences ( old code vs new code )

[RMacfarlane]

Closing as a duplicate of #486