Option to Choose Base for Diff

[sedghi]

Currently, when performing a review in GitHub, the first round shows the changed files against the upstream base. However, in subsequent rounds of review, the diff is based on the previous commit, making it difficult to compare changes against the latest upstream base.

Is there anywhere that I can choose the base for the diff?

[alexr00]

You can show the "Changes since last review" using the action in the tree view, but there's currently no way to choose a specific base.

[sedghi]

Thanks for the reply.
Is there a reason why I don't see that option?

[alexr00]

"Changes since last review" changes the base for the whole PR you have checked out (though an individual file option is a good idea), so it's on the root of the tree in your screenshot. For non-checked out PRs it's on the description node

[sedghi]

Oh I didn't see it there, and honestly didn't expect it there either. Thanks! it works great as I see now, but option to choose the base would be awesome

[bogdando]

That's a nice to have, indeed! When there is an update pushed over a pull request, resulting in messages like:

force-pushed the foo branch from <sha1> to <sha2> ... Compare
It would be a much welcome feature to get that difference in the addon interface

Oh I didn't see it there, and honestly didn't expect it there either. Thanks! it works great as I see now, but option to choose the base would be awesome

I'm not sure that "Changes since last review" option shows new changes for a file previously marked as viewed, but rather new files since the last change and integrating all changes from the creation of a pull request as a whole?

To clarify, if a new file was added, then changed, that option would still show the new file in the diff, instead of showing exactly new changes in it

[bogdando]

regarding implementation, that could be done by tracking multiple local branches for each PR, like gerrit revisions for a change-set, then picking the previous revision (another pr-xxx branch) as a new base for the diff