Repo is null error when the remote url has username in it

[arjunattam]

The extension is not able to fetch pull requests when the origin remote url has the following format, with the error "repo is null".

https://username@github.com/username/reponame.git

Changing the url to remove the username@ fixes the issue. Ideally the username/password modifier should be handled in the url parser.

[rebornix]

This issue would be addressed once we have #94 merged.

@shana would we use the username/password or token in scp like remote url for authentication ?

[shana]

If there's only a username in the url, then we should probably ignore it, as there's no authentication happening at that level. What the username@ portion is doing in the url is hinting to the git credential manager that it should look up a username@github.com entry in the system if there is one. If there isn't, it might fall back to looking for an entry with only the host portion (or fail, it's really iffy). Since we only deal with host+token pairs, the username isn't much help as a key (we have no idea what the username is for a token unless we ping the api for it).

If there's a username+password in the url, then that might be useful. That is, assuming that the password is a token, and that the token has the correct scopes that the PR feature needs (so basically it's the same scenario where we look up the token from git and check whether the token is usable).

[rebornix]

@shana thanks for the detailed information. To unblock users from using this extension in this case, I'll ignore the username/token for now. We can use this issue to continue investigating how we can use the user/token info for authentication.

[RMacfarlane]

This has been fixed by ff9cfa1