Found 5 issues. Generating a markdown table of the first 10…#6390
Merged
Found 5 issues. Generating a markdown table of the first 10…#6390
Conversation
aiday-mar
approved these changes
Oct 23, 2024
benibenj
reviewed
Oct 23, 2024
| const actualDisplay = Math.min(maxDisplay, foundIssuesCount); | ||
| return { | ||
| invocationMessage: vscode.l10n.t('Found {0} issues. Generating a markdown table of the first 10', options.parameters.totalIssues) | ||
| invocationMessage: vscode.l10n.t('Found {0} issues. Generating a markdown table of the first {1}', foundIssuesCount, actualDisplay) |
Contributor
There was a problem hiding this comment.
@alexr00 If foundIssuesCount is smaller than actualDisplay I don't think it should mention ... of the first {1}.
I would expect:
Found 4654 issues. Generating a markdown table of the first 10…Found 5 issues. Generating a markdown table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6364