Add prepareInvocation definition which contains a link to the item of interest#6409
Merged
Add prepareInvocation definition which contains a link to the item of interest#6409
Conversation
lszomoru
approved these changes
Oct 24, 2024
alexr00
reviewed
Oct 24, 2024
Comment on lines
+3320
to
+3323
| "itemType": { | ||
| "type": "string", | ||
| "description": "The type of the item in the notification - whether it is an issue or a PR" | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| "itemType": { | |
| "type": "string", | |
| "description": "The type of the item in the notification - whether it is an issue or a PR" | |
| }, | |
| "itemType": { | |
| "type": "string", | |
| "enum": [ | |
| "issue", | |
| "pr" | |
| ], | |
| "description": "The type of the item in the notification - whether it is an issue or a PR" | |
| }, |
| const type = parameters.itemType === 'issue' ? 'issues' : 'pull'; | ||
| const url = `https://github.com/${parameters.owner}/${parameters.repo}/${type}/${parameters.itemNumber}`; | ||
| return { | ||
| invocationMessage: vscode.l10n.t('Fetching item [#{0}]({1}) from GitHub', parameters.itemNumber, url) |
Member
There was a problem hiding this comment.
Suggested change
| invocationMessage: vscode.l10n.t('Fetching item [#{0}]({1}) from GitHub', parameters.itemNumber, url) | |
| invocationMessage: type === 'issue' ? vscode.l10n.t('Fetching issue [#{0}]({1}) from GitHub', parameters.itemNumber, url) : vscode.l10n.t('Fetching pull request [#{0}]({1}) from GitHub', parameters.itemNumber, url) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6339
fixes #6340