Skip to content

Handling undefined values in summarize notifications tool#6421

Merged
aiday-mar merged 9 commits intorelease/0.100from
unexpected-nightingale
Oct 25, 2024
Merged

Handling undefined values in summarize notifications tool#6421
aiday-mar merged 9 commits intorelease/0.100from
unexpected-nightingale

Conversation

@aiday-mar
Copy link
Copy Markdown
Contributor

@aiday-mar aiday-mar commented Oct 25, 2024 •
edited
Loading

  • Checking whether the parameters are defined before using them
  • Renaming unreadComments to comments because the LLM behind seems to send the unreadComments as a comments array

@aiday-mar aiday-mar changed the base branch from main to release/0.100 October 25, 2024 09:07
@aiday-mar aiday-mar requested review from alexr00 and lszomoru October 25, 2024 09:07
@aiday-mar aiday-mar marked this pull request as ready for review October 25, 2024 09:07
@aiday-mar aiday-mar added the candidate Issue identified as probable candidate for fixing in the next release label Oct 25, 2024
alexr00
alexr00 reviewed Oct 25, 2024
View reviewed changes
Comment thread src/lm/tools/fetchNotificationTool.ts
alexr00
alexr00 requested changes Oct 25, 2024
View reviewed changes
Comment thread src/lm/tools/summarizeNotificationsTool.ts Outdated
Comment thread src/lm/tools/fetchNotificationTool.ts
@aiday-mar
Copy link
Copy Markdown
Contributor Author

aiday-mar commented Oct 25, 2024 •
edited
Loading

Thanks for the review! I made the requested changes

alexr00
alexr00 previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread src/lm/tools/summarizeNotificationsTool.ts Outdated
This was referenced Oct 25, 2024
Closed
Closed
@aiday-mar aiday-mar merged commit 7c3da33 into release/0.100 Oct 25, 2024
@aiday-mar aiday-mar deleted the unexpected-nightingale branch October 25, 2024 13:16
alexr00 added a commit that referenced this pull request Oct 28, 2024
@aiday-mar @alexr00
Handling undefined values in summarize notifications tool (#6421)
f8bae4a 
* Inaccurate result when asking for authored issues (#6419)

Part of #6362

* handling undefined values

* changing the order of the response text and tool command result

* undo change in search tools

* removing the changing of order

* review comments

* plolishing

* merging return statements

* pushing the new text model part into the summarize tool result

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
alexr00 added a commit that referenced this pull request Oct 28, 2024
@aiday-mar @alexr00
Handling undefined values in summarize notifications tool (#6421)
b799148 
* Inaccurate result when asking for authored issues (#6419)

Part of #6362

* handling undefined values

* changing the order of the response text and tool command result

* undo change in search tools

* removing the changing of order

* review comments

* plolishing

* merging return statements

* pushing the new text model part into the summarize tool result

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexr00 alexr00 alexr00 approved these changes

@lszomoru lszomoru Awaiting requested review from lszomoru

Assignees

No one assigned

Labels

candidate Issue identified as probable candidate for fixing in the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aiday-mar @alexr00