Skip to content

Improve handling of varios reviewer types #6509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 1 commit into from
Dec 4, 2024
Merged

Improve handling of varios reviewer types #6509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/github/pullRequestModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
input: {
pullRequestId: this.graphNodeId,
teamIds: teamReviewers,
userIds: reviewers
userIds: reviewers.filter(r => !r.startsWith('BOT')),
},
},
});
Expand Down
16 changes: 10 additions & 6 deletions src/github/queriesShared.gql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,14 @@ fragment Review on PullRequestReview {
login
avatarUrl
url
... on Node {
id
}
... on User {
email
id
}
... on Organization {
email
id
}
}
state
Expand Down Expand Up @@ -318,20 +319,23 @@ query GetReviewRequestsAdditionalScopes($owner: String!, $name: String!, $number
reviewRequests(first: 100) {
nodes {
requestedReviewer {
... on User {
... on Node {
id
}
... on Actor {
login
avatarUrl
id
}
... on User {
url
email
name
}
... on Team {
... on Team { # Team is not an Actor
name
avatarUrl
url
slug
id
}
}
}
Expand Down