Skip to content

Non GitHub remotes for submodules causes authentication to fail #6562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 1 commit into from
Dec 18, 2024
Merged

Non GitHub remotes for submodules causes authentication to fail #6562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/view/prsTreeDataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,23 +235,24 @@ export class PullRequestsTreeDataProvider extends Disposable implements vscode.T
return this.needsRemotes();
}

const gitHubFolderManagers = this._reposManager.folderManagers.filter(manager => manager.gitHubRepositories.length > 0);
if (!element) {
if (this._children && this._children.length) {
this._children.forEach(dispose => dispose.dispose());
}

let result: WorkspaceFolderNode[] | CategoryTreeNode[];
if (this._reposManager.folderManagers.length === 1) {
if (gitHubFolderManagers.length === 1) {
result = WorkspaceFolderNode.getCategoryTreeNodes(
this._reposManager.folderManagers[0],
gitHubFolderManagers[0],
this._telemetry,
this,
this.notificationProvider,
this._context,
this.prsTreeModel
);
} else {
result = this._reposManager.folderManagers.map(
result = gitHubFolderManagers.map(
folderManager =>
new WorkspaceFolderNode(
this,
Expand All @@ -270,7 +271,7 @@ export class PullRequestsTreeDataProvider extends Disposable implements vscode.T
}

if (
this._reposManager.folderManagers.filter(manager => manager.repository.state.remotes.length > 0).length === 0
gitHubFolderManagers.filter(manager => manager.repository.state.remotes.length > 0).length === 0
) {
return Promise.resolve([new PRCategoryActionNode(this, PRCategoryActionType.Empty)]);
}
Expand Down
1 change: 0 additions & 1 deletion src/view/treeNodes/repositoryChangesNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export class RepositoryChangesNode extends DescriptionNode implements vscode.Tre
public description?: string;
readonly collapsibleState = vscode.TreeItemCollapsibleState.Expanded;


constructor(
public override parent: BaseTreeNode,
pullRequest: PullRequestModel,
Expand Down