Skip to content

Changing issue assignees has bad progress reporting #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 1 commit into from
Apr 29, 2025
Merged

Changing issue assignees has bad progress reporting #6877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/github/issueOverview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
const hidePromise = asPromise<void>(quickPick.onDidHide);
const labelsToAdd = await Promise.race<readonly vscode.QuickPickItem[] | void>([acceptPromise, hidePromise]);
quickPick.busy = true;
quickPick.enabled = false;

if (labelsToAdd) {
await this._item.setLabels(labelsToAdd.map(r => r.label));
Expand Down Expand Up @@ -393,6 +394,7 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
const hidePromise = asPromise<void>(quickPick.onDidHide);
const allAssignees = await Promise.race<(vscode.QuickPickItem & { user: IAccount })[] | void>([acceptPromise, hidePromise]);
quickPick.busy = true;
quickPick.enabled = false;

if (allAssignees) {
const newAssignees: IAccount[] = allAssignees.map(item => item.user);
Expand Down
1 change: 1 addition & 0 deletions src/github/pullRequestOverview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
const hidePromise = asPromise<void>(quickPick.onDidHide);
const allReviewers = await Promise.race<(IAccount | ITeam)[] | void>([acceptPromise, hidePromise]);
quickPick.busy = true;
quickPick.enabled = false;

if (allReviewers) {
const newUserReviewers: IAccount[] = [];
Expand Down