Skip to content

Fix completing review from the webview view #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 1 commit into from
May 12, 2025
+7 −6
Merged

Fix completing review from the webview view #6947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/github/activityBarViewProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { PullRequestModel } from './pullRequestModel';
import { getDefaultMergeMethod } from './pullRequestOverview';
import { PullRequestView } from './pullRequestOverviewCommon';
import { isInCodespaces, parseReviewers } from './utils';
import { MergeArguments, PullRequest, ReviewType } from './views';
import { MergeArguments, PullRequest, ReviewType, SubmitReviewReply } from './views';

export class PullRequestViewProvider extends WebviewViewBase implements vscode.WebviewViewProvider {
public override readonly viewType = 'github:activePullRequest';
Expand Down Expand Up @@ -362,7 +362,7 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W
try {
const review = await action(context.body);
this.updateReviewers(review);
const reviewMessage = {
const reviewMessage: SubmitReviewReply & { command: string } = {
command: 'pr.append-review',
event: review,
reviewers: this._existingReviewers
Expand All @@ -379,10 +379,11 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W
try {
const review = await action(message.args);
this.updateReviewers(review);
this._replyMessage(message, {
review: review,
const reviewMessage: SubmitReviewReply = {
event: review,
reviewers: this._existingReviewers,
});
};
this._replyMessage(message, reviewMessage);
} catch (e) {
vscode.window.showErrorMessage(vscode.l10n.t('Submitting review failed. {0}', formatError(e)));
this._throwError(message, `${formatError(e)}`);
Expand Down
2 changes: 1 addition & 1 deletion src/github/pullRequestOverview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
try {
const review = await action(context.body);
this.updateReviewers(review);
const reviewMessage = {
const reviewMessage: SubmitReviewReply & { command: string } = {
command: 'pr.append-review',
event: review,
reviewers: this._existingReviewers
Expand Down