Merged
Conversation
connor4312
approved these changes
Aug 6, 2025
alexr00
reviewed
Aug 7, 2025
| return false; | ||
| } | ||
|
|
||
| const eventTime = new Date( |
Member
There was a problem hiding this comment.
There's a utility for getting the event time!
vscode-pull-request-github/src/github/utils.ts
Lines 1060 to 1061 in 73e670b
Member
There was a problem hiding this comment.
Looks like this utility is going to be very useful throughout this file.
alexr00
reviewed
Aug 7, 2025
Comment on lines
+163
to
+169
| if (event.event === EventType.Commented) { | ||
| const comment = event as CommentEvent; | ||
| return comment.body.includes('@copilot') || comment.body.includes(this.handler); | ||
| } else if (event.event === EventType.Reviewed) { | ||
| const review = event as ReviewEvent; | ||
| return review.body.includes('@copilot') || review.body.includes(this.handler); | ||
| } |
Member
There was a problem hiding this comment.
This can be simplified:
Suggested change
| if (event.event === EventType.Commented) { | |
| const comment = event as CommentEvent; | |
| return comment.body.includes('@copilot') || comment.body.includes(this.handler); | |
| } else if (event.event === EventType.Reviewed) { | |
| const review = event as ReviewEvent; | |
| return review.body.includes('@copilot') || review.body.includes(this.handler); | |
| } | |
| if (event.event === EventType.Commented || event.event === EventType.Reviewed) { | |
| return event.body.includes('@copilot') || event.body.includes(this.handler); | |
| } |
Member
There was a problem hiding this comment.
Same change can apply in the other places that you access body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting and refactored copilotRemoteAgent