Skip to content

Improve chat session log parsing for active response. #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebornix merged 1 commit into from
Sep 2, 2025
Merged

Improve chat session log parsing for active response. #7739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions common/sessionParsing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,34 @@ export function parseToolCallDetails(
} : undefined
};
}
} else if (name === 'str_replace') {
const filePath = args.path;
const fileLabel = filePath && toFileLabel(filePath);

return {
toolName: 'Edit',
invocationMessage: fileLabel ? `Edit [](${fileLabel})` : `Edit ${filePath}`,
pastTenseMessage: fileLabel ? `Edit [](${fileLabel})` : `Edit ${filePath}`,
toolSpecificData: fileLabel ? {
command: 'str_replace',
filePath: filePath,
fileLabel: fileLabel,
} : undefined
}
} else if (name === 'create') {
Copy link
Copy Markdown
Member

@alexr00 alexr00 Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if statement is getting huge! It would be great if we could clean it up a bit during debt week.

const filePath = args.path;
const fileLabel = filePath && toFileLabel(filePath);

return {
toolName: 'Create',
invocationMessage: fileLabel ? `Create [](${fileLabel})` : `Create File ${filePath}`,
pastTenseMessage: fileLabel ? `Create [](${fileLabel})` : `Create File ${filePath}`,
toolSpecificData: fileLabel ? {
command: 'create',
filePath: filePath,
fileLabel: fileLabel,
} : undefined
}
} else if (name === 'view') {
const filePath = args.path;
const fileLabel = filePath && toFileLabel(filePath);
Expand Down
4 changes: 2 additions & 2 deletions src/github/copilotRemoteAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,8 +1082,8 @@ export class CopilotRemoteAgentManager extends Disposable {
const delta = choice.delta;

if (delta.role === 'assistant') {
// Handle special case for run_custom_setup_step
if (choice.finish_reason === 'tool_calls' && delta.tool_calls?.length && delta.tool_calls[0].function.name === 'run_custom_setup_step') {
// Handle special case for run_custom_setup_step/run_setup
if (choice.finish_reason === 'tool_calls' && delta.tool_calls?.length && (delta.tool_calls[0].function.name === 'run_custom_setup_step' || delta.tool_calls[0].function.name === 'run_setup')) {
const toolCall = delta.tool_calls[0];
let args: any = {};
try {
Expand Down