Remove cleanPrompt method from CopilotRemoteAgentManager#7750
Merged
joshspicer merged 2 commits intomainfrom Sep 3, 2025
Merged
Remove cleanPrompt method from CopilotRemoteAgentManager#7750joshspicer merged 2 commits intomainfrom
joshspicer merged 2 commits intomainfrom
Conversation
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] remove 'cleanPrompt' from copilotRemoteAgent
Remove cleanPrompt method from CopilotRemoteAgentManager
Sep 3, 2025
joshspicer
approved these changes
Sep 3, 2025
Tyriar
approved these changes
Sep 3, 2025
rebornix
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
cleanPromptmethod from theCopilotRemoteAgentManagerclass as requested. The method was previously used to strip#file:xxxxpatterns from user prompts before processing them.Changes Made
cleanPrompt(prompt: string): stringmethod fromCopilotRemoteAgentManagerprovideNewChatSessionItemmethod to useoptions.promptdirectly instead of callingthis.cleanPrompt(options.prompt)Impact
With this change, prompts will no longer be automatically cleaned of
#file:xxxxpatterns. The prompts will be processed as-is without any modification. This affects the behavior in theprovideNewChatSessionItemmethod where prompts are prepared for new coding agent sessions.The changes are minimal and surgical - only 4 lines were removed (the method definition) and 1 line was modified (the direct usage of the prompt).
Verification
cleanPromptin the codebaseWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com/opt/hostedtoolcache/node/20.19.4/x64/bin/node ./out/src/test/runTests.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Created from VS Code via the GitHub Pull Request extension.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.