Skip to content

Remove cleanPrompt method from CopilotRemoteAgentManager#7750

Merged
joshspicer merged 2 commits intomainfrom
copilot/fix-b92b53ce-fa95-4998-bc7d-58ca660f462f
Sep 3, 2025
Merged

Remove cleanPrompt method from CopilotRemoteAgentManager#7750
joshspicer merged 2 commits intomainfrom
copilot/fix-b92b53ce-fa95-4998-bc7d-58ca660f462f

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 3, 2025

This PR removes the cleanPrompt method from the CopilotRemoteAgentManager class as requested. The method was previously used to strip #file:xxxx patterns from user prompts before processing them.

Changes Made

  • Removed the cleanPrompt(prompt: string): string method from CopilotRemoteAgentManager
  • Updated the provideNewChatSessionItem method to use options.prompt directly instead of calling this.cleanPrompt(options.prompt)

Impact

With this change, prompts will no longer be automatically cleaned of #file:xxxx patterns. The prompts will be processed as-is without any modification. This affects the behavior in the provideNewChatSessionItem method where prompts are prepared for new coding agent sessions.

The changes are minimal and surgical - only 4 lines were removed (the method definition) and 1 line was modified (the direct usage of the prompt).

Verification

  • ✅ Code compiles successfully
  • ✅ Linting passes
  • ✅ Hygiene checks pass
  • ✅ No remaining references to cleanPrompt in the codebase

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • update.code.visualstudio.com
    • Triggering command: /opt/hostedtoolcache/node/20.19.4/x64/bin/node ./out/src/test/runTests.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Created from VS Code via the GitHub Pull Request extension.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Copilot AI changed the title [WIP] remove 'cleanPrompt' from copilotRemoteAgent Remove cleanPrompt method from CopilotRemoteAgentManager Sep 3, 2025
Copilot AI requested a review from joshspicer September 3, 2025 14:41
@joshspicer joshspicer marked this pull request as ready for review September 3, 2025 15:29
@joshspicer joshspicer enabled auto-merge (squash) September 3, 2025 15:29
@vs-code-engineering vs-code-engineering Bot added this to the August 2025 milestone Sep 3, 2025
@joshspicer joshspicer merged commit 5e2053e into main Sep 3, 2025
3 checks passed
@joshspicer joshspicer deleted the copilot/fix-b92b53ce-fa95-4998-bc7d-58ca660f462f branch September 3, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants