Skip to content

do not exclude markdown when detecting comment for Delegate codelens#8044

Merged
joshspicer merged 1 commit intomainfrom
joshspicer/todo-markdown
Oct 24, 2025
Merged

do not exclude markdown when detecting comment for Delegate codelens#8044
joshspicer merged 1 commit intomainfrom
joshspicer/todo-markdown

Conversation

@joshspicer
Copy link
Copy Markdown
Member

@joshspicer joshspicer commented Oct 24, 2025

Before

image

After

image

@joshspicer
Copy link
Copy Markdown
Member Author

cc/ @alexr00 I am not sure why isComment excludes markdown (forcing it to return true) in the first place. I did this change to avoid a behavior change in other places, but may want to change the default behavior of isComment?

@joshspicer joshspicer merged commit 6db883c into main Oct 24, 2025
6 checks passed
@joshspicer joshspicer deleted the joshspicer/todo-markdown branch October 24, 2025 16:09
@alexr00
Copy link
Copy Markdown
Member

alexr00 commented Oct 27, 2025

It's because we always want to show the issue completion provider and issue link provider (which is actually disabled) in markdown. But, this can be moved into the issue completion provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants