Skip to content

Dispose of post commit command providers #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 2 commits into from
Nov 6, 2025
Merged

Dispose of post commit command providers #8109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d664d
Dispose of post commit command providers
alexr00 Nov 6, 2025
5282130
Merge branch 'main' into alexr00/hollow-pig
alexr00 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ async function init(

await vscode.commands.executeCommand('setContext', 'github:initialized', true);

registerPostCommitCommandsProvider(reposManager, git);
registerPostCommitCommandsProvider(context, reposManager, git);

// Resume any pending checkout request stored before workspace reopened.
await resumePendingCheckout(reviewsManager, context, reposManager);
Expand Down Expand Up @@ -350,7 +350,7 @@ async function doRegisterBuiltinGitProvider(context: vscode.ExtensionContext, cr
return false;
}

function registerPostCommitCommandsProvider(reposManager: RepositoriesManager, git: GitApiImpl) {
function registerPostCommitCommandsProvider(context: vscode.ExtensionContext, reposManager: RepositoriesManager, git: GitApiImpl) {
const componentId = 'GitPostCommitCommands';
class Provider implements PostCommitCommandsProvider {

Expand Down Expand Up @@ -379,7 +379,7 @@ function registerPostCommitCommandsProvider(reposManager: RepositoriesManager, g
Logger.appendLine('Trying to register post commit commands.', 'GitPostCommitCommands');
if (hasGitHubRepos()) {
Logger.appendLine('GitHub remote(s) found, registering post commit commands.', componentId);
git.registerPostCommitCommandsProvider(new Provider());
context.subscriptions.push(git.registerPostCommitCommandsProvider(new Provider()));
return true;
}
return false;
Expand Down