Suppress RemoveReaction permission errors during rapid reaction toggling#8225
Merged
Suppress RemoveReaction permission errors during rapid reaction toggling#8225
Conversation
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
When users quickly click on a reaction to add/remove it, a race condition can occur where the client tries to remove a reaction that the user doesn't have permission to remove. This results in a GraphQL error: "does not have the correct permissions to execute 'RemoveReaction'" This change silently ignores this specific error as it's expected behavior during rapid toggling of reactions. Fixes microsoft/vscode#69321 Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
…entations - Import formatError in pullRequestCommentController.ts - Use formatError(e) consistently in both implementations - Throw new Error(errorMessage) consistently instead of rethrowing original error Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GraphQL error when adding and removing reactions
Suppress RemoveReaction permission errors during rapid reaction toggling
Dec 9, 2025
alexr00
approved these changes
Dec 11, 2025
bpasero
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race condition when rapidly toggling reactions causes permission errors as the client attempts to remove reactions that don't belong to the user or are already removed server-side.
Changes
toggleReaction: Catch and silently ignore RemoveReaction permission errors in bothreviewCommentController.tsandpullRequestCommentController.ts'does not have the correct permissions to execute \'RemoveReaction\''(consistent with existing GraphQL error handling throughout the codebase)formatError()and re-wrap in both implementationsAll other errors remain unhandled to preserve existing behavior.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.