Skip to content

Improve button and branch tag styling#8369

Merged
mrleemurray merged 7 commits intomainfrom
mrleemurray/wittering-rat-magenta
Jan 7, 2026
Merged

Improve button and branch tag styling#8369
mrleemurray merged 7 commits intomainfrom
mrleemurray/wittering-rat-magenta

Conversation

@mrleemurray
Copy link
Copy Markdown
Contributor

Update the CSS for button elements to enhance visibility with borders and adjust the styling of branch tags for better alignment and spacing.

Copilot AI review requested due to automatic review settings January 7, 2026 13:46
@mrleemurray mrleemurray enabled auto-merge (squash) January 7, 2026 13:46
@mrleemurray mrleemurray self-assigned this Jan 7, 2026
@mrleemurray mrleemurray added this to the December 2025 milestone Jan 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the visual styling of button elements and branch tags in the webview components. The changes add border styling to improve visibility and adjust spacing for better alignment.

  • Adds consistent border styling to various button types using VS Code theme variables
  • Adjusts branch tag margin and padding for improved spacing
  • Enhances the change-base button component with better alignment and icon spacing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
webviews/editorWebview/index.css Updates branch tag spacing (margin/padding) and adds styling improvements to change-base button including alignment, padding, and icon spacing
webviews/common/common.css Adds border styling to secondary buttons, disabled buttons, and split button components for enhanced visibility

Comment thread webviews/editorWebview/index.css Outdated
Comment thread webviews/common/common.css
Comment thread webviews/editorWebview/index.css Outdated
Comment thread webviews/common/common.css Outdated
Comment thread webviews/common/common.css Outdated
Copy link
Copy Markdown
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrleemurray do we want this border on all secondary buttons?
image

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 7, 2026 15:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mrleemurray and others added 2 commits January 7, 2026 15:19
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread webviews/common/common.css Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 7, 2026 15:25
@mrleemurray
Copy link
Copy Markdown
Contributor Author

mrleemurray commented Jan 7, 2026

@alexr00 yes, secondary buttons should have a border to align with the rest of the product UI:
image

It also improves the visibility of buttons in high contrast themes:

image

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread webviews/common/common.css
Copy link
Copy Markdown
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, thank you!

@mrleemurray mrleemurray merged commit 32d1cf6 into main Jan 7, 2026
12 checks passed
@mrleemurray mrleemurray deleted the mrleemurray/wittering-rat-magenta branch January 7, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants