Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds test coverage and a reusable utility for HTML-escaping file paths/names when injecting them into data-local-file attributes, addressing CCR feedback around safe link processing.
Changes:
- Export
escapeHtmlAttrfromsrc/common/utils.tsand refactor it to a single-pass replacement. - Add tests verifying
processPermalinks/processDiffLinksoutput escapes special characters. - Add unit tests for
escapeHtmlAttracross common special-character cases.
Show a summary per file
| File | Description |
|---|---|
| src/test/common/utils.test.ts | Adds coverage for escaping in processed permalink/diff links and direct tests for escapeHtmlAttr. |
| src/common/utils.ts | Exports and refactors escapeHtmlAttr used to escape data-local-file attribute values. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
ulugbekna
approved these changes
Apr 13, 2026
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.