Skip to content

Try to get error code better from failure to get PR#8694

Merged
alexr00 merged 2 commits intomainfrom
alexr00/hilarious-rook
Apr 23, 2026
Merged

Try to get error code better from failure to get PR#8694
alexr00 merged 2 commits intomainfrom
alexr00/hilarious-rook

Conversation

@alexr00
Copy link
Copy Markdown
Member

@alexr00 alexr00 commented Apr 23, 2026

Co-authored-by: Copilot copilot@github.com

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 23, 2026 08:35
@alexr00 alexr00 enabled auto-merge (squash) April 23, 2026 08:35
@alexr00 alexr00 self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves telemetry diagnostics when GitHubRepository.getPullRequest fails, by extracting a more useful errorCode from additional error shapes encountered during GraphQL/API failures.

Changes:

  • Add fallback extraction of errorCode from networkError.statusCode.
  • Add additional fallbacks for errorCode from e.code and e.name when other fields aren’t present.
Show a summary per file
File Description
src/github/githubRepository.ts Expands telemetry errorCode derivation in getPullRequest failure handling to capture more error variants.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/github/githubRepository.ts Outdated
Co-authored-by: Copilot <copilot@github.com>
@alexr00 alexr00 merged commit 16573c9 into main Apr 23, 2026
6 checks passed
@alexr00 alexr00 deleted the alexr00/hilarious-rook branch April 23, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants