Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves type-safety in githubRepository.ts by tightening getErrorCode’s input type and adding guarded property access, reducing reliance on any when extracting error codes for logging/telemetry.
Changes:
- Introduces a local
isObjecttype guard for safe property probing onunknown. - Updates
getErrorCodesignature fromanytounknownand rewrites extraction logic with explicit runtime checks. - Preserves existing behavior for known error shapes (
status,networkError.statusCode, GraphQL extensions code,code,name).
Show a summary per file
| File | Description |
|---|---|
| src/github/githubRepository.ts | Makes getErrorCode more type-safe by using unknown + runtime narrowing for error-code extraction. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
lramos15
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.